Re: [PATCH] regulator: add regulator_sync_voltage inline dummy

2015-12-08 Thread Mark Brown
On Tue, Dec 08, 2015 at 05:49:20PM +0100, Arnd Bergmann wrote: > On Tuesday 08 December 2015 16:37:39 Mark Brown wrote: > > On Tue, Dec 08, 2015 at 04:43:35PM +0100, Arnd Bergmann wrote: > > We don't do this for *all* regulator API functions - there's some where > > using them strongly suggests

Re: [PATCH] regulator: add regulator_sync_voltage inline dummy

2015-12-08 Thread Arnd Bergmann
On Tuesday 08 December 2015 16:37:39 Mark Brown wrote: > On Tue, Dec 08, 2015 at 04:43:35PM +0100, Arnd Bergmann wrote: > > > This modifies the API header so we provide a static inline function > > with the same prototype as the normal function of this name. This matches > > what we do for all

Re: [PATCH] regulator: add regulator_sync_voltage inline dummy

2015-12-08 Thread Mark Brown
On Tue, Dec 08, 2015 at 04:43:35PM +0100, Arnd Bergmann wrote: > This modifies the API header so we provide a static inline function > with the same prototype as the normal function of this name. This matches > what we do for all other regulator API functions and avoids the build > error. We

[PATCH] regulator: add regulator_sync_voltage inline dummy

2015-12-08 Thread Arnd Bergmann
Only one driver calls regulator_sync_voltage(), but that driver can currently be built with CONFIG_REGULATOR disabled, producing this build error: drivers/cpufreq/tegra124-cpufreq.c: In function 'tegra124_cpu_switch_to_pllx': drivers/cpufreq/tegra124-cpufreq.c:68:2: error: implicit declaration of

Re: [PATCH] regulator: add regulator_sync_voltage inline dummy

2015-12-08 Thread Mark Brown
On Tue, Dec 08, 2015 at 05:49:20PM +0100, Arnd Bergmann wrote: > On Tuesday 08 December 2015 16:37:39 Mark Brown wrote: > > On Tue, Dec 08, 2015 at 04:43:35PM +0100, Arnd Bergmann wrote: > > We don't do this for *all* regulator API functions - there's some where > > using them strongly suggests

Re: [PATCH] regulator: add regulator_sync_voltage inline dummy

2015-12-08 Thread Arnd Bergmann
On Tuesday 08 December 2015 16:37:39 Mark Brown wrote: > On Tue, Dec 08, 2015 at 04:43:35PM +0100, Arnd Bergmann wrote: > > > This modifies the API header so we provide a static inline function > > with the same prototype as the normal function of this name. This matches > > what we do for all

Re: [PATCH] regulator: add regulator_sync_voltage inline dummy

2015-12-08 Thread Mark Brown
On Tue, Dec 08, 2015 at 04:43:35PM +0100, Arnd Bergmann wrote: > This modifies the API header so we provide a static inline function > with the same prototype as the normal function of this name. This matches > what we do for all other regulator API functions and avoids the build > error. We

[PATCH] regulator: add regulator_sync_voltage inline dummy

2015-12-08 Thread Arnd Bergmann
Only one driver calls regulator_sync_voltage(), but that driver can currently be built with CONFIG_REGULATOR disabled, producing this build error: drivers/cpufreq/tegra124-cpufreq.c: In function 'tegra124_cpu_switch_to_pllx': drivers/cpufreq/tegra124-cpufreq.c:68:2: error: implicit declaration of