Re: [PATCH] resolve duplicate flag no for PG_lazyfree

2007-05-15 Thread Nick Piggin
Andrew Morton wrote: On Mon, 14 May 2007 14:06:19 -0400 Theodore Tso <[EMAIL PROTECTED]> wrote: On Sun, May 13, 2007 at 10:46:30PM -0700, Andrew Morton wrote: otoh, the intersection between pages which are PageBooked() and pages which are PageLazyFree() should be zreo, so it'd be good to

Re: [PATCH] resolve duplicate flag no for PG_lazyfree

2007-05-15 Thread Nick Piggin
Andrew Morton wrote: On Mon, 14 May 2007 14:06:19 -0400 Theodore Tso [EMAIL PROTECTED] wrote: On Sun, May 13, 2007 at 10:46:30PM -0700, Andrew Morton wrote: otoh, the intersection between pages which are PageBooked() and pages which are PageLazyFree() should be zreo, so it'd be good to

Re: [PATCH] resolve duplicate flag no for PG_lazyfree

2007-05-14 Thread Andrew Morton
On Mon, 14 May 2007 14:06:19 -0400 Theodore Tso <[EMAIL PROTECTED]> wrote: > On Sun, May 13, 2007 at 10:46:30PM -0700, Andrew Morton wrote: > > otoh, the intersection between pages which are PageBooked() and pages which > > are PageLazyFree() should be zreo, so it'd be good to actually formalise

Re: [PATCH] resolve duplicate flag no for PG_lazyfree

2007-05-14 Thread Theodore Tso
On Sun, May 13, 2007 at 10:46:30PM -0700, Andrew Morton wrote: > otoh, the intersection between pages which are PageBooked() and pages which > are PageLazyFree() should be zreo, so it'd be good to actually formalise > this reuse within the ext4 patches. > > otoh2, PageLazyFree() could have reused

Re: [PATCH] resolve duplicate flag no for PG_lazyfree

2007-05-14 Thread Fengguang Wu
On Sun, May 13, 2007 at 10:46:30PM -0700, Andrew Morton wrote: > On Mon, 14 May 2007 10:37:18 +0800 Fengguang Wu <[EMAIL PROTECTED]> wrote: > > > PG_lazyfree and PG_booked shares the same bit. > > > > Either it is a bug that shall fixed by the following patch, or > > the situation should be

Re: [PATCH] resolve duplicate flag no for PG_lazyfree

2007-05-14 Thread Fengguang Wu
On Sun, May 13, 2007 at 10:46:30PM -0700, Andrew Morton wrote: On Mon, 14 May 2007 10:37:18 +0800 Fengguang Wu [EMAIL PROTECTED] wrote: PG_lazyfree and PG_booked shares the same bit. Either it is a bug that shall fixed by the following patch, or the situation should be explicitly

Re: [PATCH] resolve duplicate flag no for PG_lazyfree

2007-05-14 Thread Theodore Tso
On Sun, May 13, 2007 at 10:46:30PM -0700, Andrew Morton wrote: otoh, the intersection between pages which are PageBooked() and pages which are PageLazyFree() should be zreo, so it'd be good to actually formalise this reuse within the ext4 patches. otoh2, PageLazyFree() could have reused

Re: [PATCH] resolve duplicate flag no for PG_lazyfree

2007-05-14 Thread Andrew Morton
On Mon, 14 May 2007 14:06:19 -0400 Theodore Tso [EMAIL PROTECTED] wrote: On Sun, May 13, 2007 at 10:46:30PM -0700, Andrew Morton wrote: otoh, the intersection between pages which are PageBooked() and pages which are PageLazyFree() should be zreo, so it'd be good to actually formalise this

Re: [PATCH] resolve duplicate flag no for PG_lazyfree

2007-05-13 Thread Andrew Morton
On Mon, 14 May 2007 10:37:18 +0800 Fengguang Wu <[EMAIL PROTECTED]> wrote: > PG_lazyfree and PG_booked shares the same bit. > > Either it is a bug that shall fixed by the following patch, or > the situation should be explicitly documented? > > Signed-off-by: Fengguang Wu <[EMAIL PROTECTED]> >

[PATCH] resolve duplicate flag no for PG_lazyfree

2007-05-13 Thread Fengguang Wu
PG_lazyfree and PG_booked shares the same bit. Either it is a bug that shall fixed by the following patch, or the situation should be explicitly documented? Signed-off-by: Fengguang Wu <[EMAIL PROTECTED]> --- include/linux/page-flags.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH] resolve duplicate flag no for PG_lazyfree

2007-05-13 Thread Fengguang Wu
PG_lazyfree and PG_booked shares the same bit. Either it is a bug that shall fixed by the following patch, or the situation should be explicitly documented? Signed-off-by: Fengguang Wu [EMAIL PROTECTED] --- include/linux/page-flags.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---

Re: [PATCH] resolve duplicate flag no for PG_lazyfree

2007-05-13 Thread Andrew Morton
On Mon, 14 May 2007 10:37:18 +0800 Fengguang Wu [EMAIL PROTECTED] wrote: PG_lazyfree and PG_booked shares the same bit. Either it is a bug that shall fixed by the following patch, or the situation should be explicitly documented? Signed-off-by: Fengguang Wu [EMAIL PROTECTED] ---