Re: [PATCH] resources: Remove unneeded initialization of local variable

2015-12-29 Thread bojan prtvar
On Tue, Dec 29, 2015 at 2:36 PM, Laurent Navet wrote: > why not directly ? > > struct region_devres *dr = devres_alloc(devm_region_release, > sizeof(struct region_devres),.. > I follow Dan's rationale [1] [1] http://www.spinics.net/lists/target-devel/msg11355.html -- To unsubscribe from this

Re: [PATCH] resources: Remove unneeded initialization of local variable

2015-12-29 Thread Laurent Navet
why not directly ? struct region_devres *dr = devres_alloc(devm_region_release, sizeof(struct region_devres),.. 2015-12-29 14:24 UTC+01:00, Bojan Prtvar : > Few lines below dr is reinitialized by devres_alloc() > so we don't need to init it by NULL in the beginning of > __devm_request_region()

[PATCH] resources: Remove unneeded initialization of local variable

2015-12-29 Thread Bojan Prtvar
Few lines below dr is reinitialized by devres_alloc() so we don't need to init it by NULL in the beginning of __devm_request_region() Signed-off-by: Bojan Prtvar --- kernel/resource.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/resource.c b/kernel/resource.c index

Re: [PATCH] resources: Remove unneeded initialization of local variable

2015-12-29 Thread bojan prtvar
On Tue, Dec 29, 2015 at 2:36 PM, Laurent Navet wrote: > why not directly ? > > struct region_devres *dr = devres_alloc(devm_region_release, > sizeof(struct region_devres),.. > I follow Dan's rationale [1] [1] http://www.spinics.net/lists/target-devel/msg11355.html -- To

[PATCH] resources: Remove unneeded initialization of local variable

2015-12-29 Thread Bojan Prtvar
Few lines below dr is reinitialized by devres_alloc() so we don't need to init it by NULL in the beginning of __devm_request_region() Signed-off-by: Bojan Prtvar --- kernel/resource.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/resource.c

Re: [PATCH] resources: Remove unneeded initialization of local variable

2015-12-29 Thread Laurent Navet
why not directly ? struct region_devres *dr = devres_alloc(devm_region_release, sizeof(struct region_devres),.. 2015-12-29 14:24 UTC+01:00, Bojan Prtvar : > Few lines below dr is reinitialized by devres_alloc() > so we don't need to init it by NULL in the beginning of >