Re: [PATCH] riscv: fixup max_low_pfn with PFN_DOWN.

2019-01-23 Thread Guo Ren
On Wed, Jan 23, 2019 at 06:00:35PM -0800, Palmer Dabbelt wrote: > On Tue, 15 Jan 2019 17:07:38 PST (-0800), guo...@kernel.org wrote: > >Hi Christoph, > > > >I use PFN_DOWN() every where as possible and seems it's a habit > >problem. So let risc-v maintainer to choose "PFN_DOW()" or > >">>

Re: [PATCH] riscv: fixup max_low_pfn with PFN_DOWN.

2019-01-23 Thread Palmer Dabbelt
On Tue, 15 Jan 2019 17:07:38 PST (-0800), guo...@kernel.org wrote: Hi Christoph, I use PFN_DOWN() every where as possible and seems it's a habit problem. So let risc-v maintainer to choose "PFN_DOW()" or ">> PAGE_SHIFT". Also the same with "end_of_DRAM & max_low_pfn". PFN_DOWN makes sense to

Re: [PATCH] riscv: fixup max_low_pfn with PFN_DOWN.

2019-01-15 Thread Guo Ren
Hi Christoph, I use PFN_DOWN() every where as possible and seems it's a habit problem. So let risc-v maintainer to choose "PFN_DOW()" or ">> PAGE_SHIFT". Also the same with "end_of_DRAM & max_low_pfn". Best Regards Guo Ren On Tue, Jan 15, 2019 at 08:12:54AM -0800, Christoph Hellwig wrote: >

Re: [PATCH] riscv: fixup max_low_pfn with PFN_DOWN.

2019-01-15 Thread Christoph Hellwig
On Wed, Jan 16, 2019 at 12:10:00AM +0800, Guo Ren wrote: > > > set_max_mapnr(PFN_DOWN(mem_size)); > > > - max_low_pfn = memblock_end_of_DRAM(); > > > + max_low_pfn = PFN_DOWN(memblock_end_of_DRAM()); > > > > I know it is used just above, but can we please just switch this > > code to use >>

Re: [PATCH] riscv: fixup max_low_pfn with PFN_DOWN.

2019-01-15 Thread Guo Ren
On Tue, Jan 15, 2019 at 07:36:13AM -0800, Christoph Hellwig wrote: > On Sat, Jan 12, 2019 at 04:16:27PM +0800, guo...@kernel.org wrote: > > From: Guo Ren > > > > max_low_pfn should be pfn_size not byte_size. > > > > Signed-off-by: Guo Ren > > Signed-off-by: Mao Han > > Cc: Palmer Dabbelt > >

Re: [PATCH] riscv: fixup max_low_pfn with PFN_DOWN.

2019-01-15 Thread Christoph Hellwig
On Sat, Jan 12, 2019 at 04:16:27PM +0800, guo...@kernel.org wrote: > From: Guo Ren > > max_low_pfn should be pfn_size not byte_size. > > Signed-off-by: Guo Ren > Signed-off-by: Mao Han > Cc: Palmer Dabbelt > Cc: Albert Ou > --- > arch/riscv/kernel/setup.c | 2 +- > arch/riscv/mm/init.c

[PATCH] riscv: fixup max_low_pfn with PFN_DOWN.

2019-01-12 Thread guoren
From: Guo Ren max_low_pfn should be pfn_size not byte_size. Signed-off-by: Guo Ren Signed-off-by: Mao Han Cc: Palmer Dabbelt Cc: Albert Ou --- arch/riscv/kernel/setup.c | 2 +- arch/riscv/mm/init.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git