Re: [PATCH] rtc: add support for maxim dallas rtc ds1343 and ds1344

2014-05-07 Thread Andrew Morton
On Wed, 7 May 2014 23:15:29 +0100 Alan Cox wrote: > On Wed, 7 May 2014 14:42:48 -0700 > Andrew Morton wrote: > > > On Wed, 7 May 2014 00:33:56 +0530 Raghavendra Ganiga > > wrote: > > > > > This is a patch to add support for >

Re: [PATCH] rtc: add support for maxim dallas rtc ds1343 and ds1344

2014-05-07 Thread Alan Cox
On Wed, 7 May 2014 14:42:48 -0700 Andrew Morton wrote: > On Wed, 7 May 2014 00:33:56 +0530 Raghavendra Ganiga > wrote: > > > This is a patch to add support for > > maxim dallas rtc ds1343 and ds1344 > > > > ... > > > > +static int ds1343_ioctl(s

Re: [PATCH] rtc: add support for maxim dallas rtc ds1343 and ds1344

2014-05-07 Thread Andrew Morton
On Wed, 7 May 2014 00:33:56 +0530 Raghavendra Ganiga wrote: > This is a patch to add support for > maxim dallas rtc ds1343 and ds1344 > > ... > > +static int ds1343_ioctl(struct device *dev, unsigned int cmd, unsigned long > arg) > +{ > + switch (cmd)

Re: [PATCH] rtc: add support for maxim dallas rtc ds1343 and ds1344

2014-05-07 Thread Andrew Morton
On Wed, 7 May 2014 00:33:56 +0530 Raghavendra Ganiga ravi23gan...@gmail.com wrote: This is a patch to add support for maxim dallas rtc ds1343 and ds1344 ... +static int ds1343_ioctl(struct device *dev, unsigned int cmd, unsigned long arg) +{ + switch (cmd) { +#ifdef

Re: [PATCH] rtc: add support for maxim dallas rtc ds1343 and ds1344

2014-05-07 Thread Alan Cox
On Wed, 7 May 2014 14:42:48 -0700 Andrew Morton a...@linux-foundation.org wrote: On Wed, 7 May 2014 00:33:56 +0530 Raghavendra Ganiga ravi23gan...@gmail.com wrote: This is a patch to add support for maxim dallas rtc ds1343 and ds1344 ... +static int ds1343_ioctl(struct device

Re: [PATCH] rtc: add support for maxim dallas rtc ds1343 and ds1344

2014-05-07 Thread Andrew Morton
for maxim dallas rtc ds1343 and ds1344 ... +static int ds1343_ioctl(struct device *dev, unsigned int cmd, unsigned long arg) +{ + switch (cmd) { +#ifdef RTC_SET_CHARGE + case RTC_SET_CHARGE: + { + int val; + + if (copy_from_user(val, (int __user *)arg

[PATCH] rtc: add support for maxim dallas rtc ds1343 and ds1344

2014-05-06 Thread Raghavendra Ganiga
This is a patch to add support for maxim dallas rtc ds1343 and ds1344 Signed-off-by: Raghavendra Chandra Ganiga --- drivers/rtc/Kconfig | 10 + drivers/rtc/Makefile |1 + drivers/rtc/rtc-ds1343.c | 679 ++ 3 files changed, 690

[PATCH] rtc: add support for maxim dallas rtc ds1343 and ds1344

2014-05-06 Thread Raghavendra Ganiga
This is a patch to add support for maxim dallas rtc ds1343 and ds1344 Signed-off-by: Raghavendra Chandra Ganiga ravi23gan...@gmail.com --- drivers/rtc/Kconfig | 10 + drivers/rtc/Makefile |1 + drivers/rtc/rtc-ds1343.c | 679 ++ 3 files

Re: [PATCH] rtc: add support for maxim dallas rtc ds1343 and ds1344

2014-04-30 Thread Alessandro Zummo
On Wed, 30 Apr 2014 21:55:07 +0530 Raghavendra Ganiga wrote: > + > +static int ds1343_proc(struct device *dev, struct seq_file *seq) > +{ > + struct ds1343_priv *priv = dev_get_drvdata(dev); > + unsigned int data; > + unsigned char alarm_mode = 0; > + const char *alarm_str,

[PATCH] rtc: add support for maxim dallas rtc ds1343 and ds1344

2014-04-30 Thread Raghavendra Ganiga
This is a patch to add support for maxim dallas rtc ds1343 and ds1344 Signed-off-by: Raghavendra Chandra Ganiga --- drivers/rtc/Kconfig | 10 + drivers/rtc/Makefile |1 + drivers/rtc/rtc-ds1343.c | 594 ++ 3 files changed, 605

[PATCH] rtc: add support for maxim dallas rtc ds1343 and ds1344

2014-04-30 Thread Raghavendra Ganiga
This is a patch to add support for maxim dallas rtc ds1343 and ds1344 Signed-off-by: Raghavendra Chandra Ganiga ravi23gan...@gmail.com --- drivers/rtc/Kconfig | 10 + drivers/rtc/Makefile |1 + drivers/rtc/rtc-ds1343.c | 594 ++ 3 files

Re: [PATCH] rtc: add support for maxim dallas rtc ds1343 and ds1344

2014-04-30 Thread Alessandro Zummo
On Wed, 30 Apr 2014 21:55:07 +0530 Raghavendra Ganiga ravi23gan...@gmail.com wrote: + +static int ds1343_proc(struct device *dev, struct seq_file *seq) +{ + struct ds1343_priv *priv = dev_get_drvdata(dev); + unsigned int data; + unsigned char alarm_mode = 0; + const char

Re: [rtc-linux] [PATCH] rtc: add support for maxim dallas rtc ds1343 and ds1344

2014-04-14 Thread Mark Brown
On Sun, Apr 13, 2014 at 08:12:57PM +0530, RAGHAVENDRA GANIGA wrote: > +static const struct spi_device_id ds1343_id[] = { > + { "ds1343", 0 }, > + { "ds1344", 1 }, > + { } > +}; > +MODULE_DEVICE_TABLE(spi, ds1343_id); If the 0 and 1 mean anything there they should have #defines,

Re: [rtc-linux] [PATCH] rtc: add support for maxim dallas rtc ds1343 and ds1344

2014-04-14 Thread Mark Brown
On Sun, Apr 13, 2014 at 08:12:57PM +0530, RAGHAVENDRA GANIGA wrote: +static const struct spi_device_id ds1343_id[] = { + { ds1343, 0 }, + { ds1344, 1 }, + { } +}; +MODULE_DEVICE_TABLE(spi, ds1343_id); If the 0 and 1 mean anything there they should have #defines, otherwise just

[PATCH] rtc: add support for maxim dallas rtc ds1343 and ds1344

2014-04-13 Thread RAGHAVENDRA GANIGA
>From 54dad3ebbce5aba4d749a14d8173e94297e14b1a Mon Sep 17 00:00:00 2001 From: Raghavendra Ganiga Date: Sun, 13 Apr 2014 20:02:59 +0530 Subject: [PATCH] rtc: add support for maxim dallas rtc ds1343 and ds1344 This is patch to add support for maxim dallas rtc ds1343 and ds1344 Signed-

[PATCH] rtc: add support for maxim dallas rtc ds1343 and ds1344

2014-04-13 Thread RAGHAVENDRA GANIGA
From 54dad3ebbce5aba4d749a14d8173e94297e14b1a Mon Sep 17 00:00:00 2001 From: Raghavendra Ganiga ravi23gan...@gmail.com Date: Sun, 13 Apr 2014 20:02:59 +0530 Subject: [PATCH] rtc: add support for maxim dallas rtc ds1343 and ds1344 This is patch to add support for maxim dallas rtc ds1343 and ds1344