Re: [PATCH] rtc: ds1307: set uie_unsupported if no interrupt is available

2021-03-30 Thread Lukasz Stelmach
It was <2021-03-30 wto 02:02>, when Alexandre Belloni wrote: > On 16/03/2021 19:04:14+0100, Lukasz Stelmach wrote: >> OK, you are right. The problem seems to be elsewhere. >> >> How about this scnario? We call rtc_update_irq_enable(). We read rtc >> with __rtc_read_time() and calculate the alarm

Re: [PATCH] rtc: ds1307: set uie_unsupported if no interrupt is available

2021-03-29 Thread Alexandre Belloni
On 16/03/2021 19:04:14+0100, Lukasz Stelmach wrote: > OK, you are right. The problem seems to be elsewhere. > > How about this scnario? We call rtc_update_irq_enable(). We read rtc > with __rtc_read_time() and calculate the alarm time. We get through > rtc_timer_enqueue() and down to

Re: [PATCH] rtc: ds1307: set uie_unsupported if no interrupt is available

2021-03-16 Thread Lukasz Stelmach
It was <2021-03-16 wto 13:32>, when Alexandre Belloni wrote: > On 16/03/2021 13:12:08+0100, Lukasz Stelmach wrote: >> It was <2021-03-15 pon 23:01>, when Alexandre Belloni wrote: >> > Hello, >> > >> > On 05/03/2021 18:44:11+0100, Łukasz Stelmach wrote: >> >> For an RTC without an IRQ assigned

Re: [PATCH] rtc: ds1307: set uie_unsupported if no interrupt is available

2021-03-16 Thread Alexandre Belloni
On 16/03/2021 13:12:08+0100, Lukasz Stelmach wrote: > It was <2021-03-15 pon 23:01>, when Alexandre Belloni wrote: > > Hello, > > > > On 05/03/2021 18:44:11+0100, Łukasz Stelmach wrote: > >> For an RTC without an IRQ assigned rtc_update_irq_enable() should > >> return -EINVAL. It will, when

Re: [PATCH] rtc: ds1307: set uie_unsupported if no interrupt is available

2021-03-16 Thread Lukasz Stelmach
It was <2021-03-15 pon 23:01>, when Alexandre Belloni wrote: > Hello, > > On 05/03/2021 18:44:11+0100, Łukasz Stelmach wrote: >> For an RTC without an IRQ assigned rtc_update_irq_enable() should >> return -EINVAL. It will, when uie_unsupported is set. >> > > I'm surprised this is an issue

[PATCH] rtc: ds1307: set uie_unsupported if no interrupt is available

2021-03-08 Thread Łukasz Stelmach
For an RTC without an IRQ assigned rtc_update_irq_enable() should return -EINVAL. It will, when uie_unsupported is set. Signed-off-by: Łukasz Stelmach --- drivers/rtc/rtc-ds1307.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/rtc/rtc-ds1307.c