Re: [PATCH] rtc: max77686: Fix the returned value in case of error in 'max77686_rtc_read_time()'

2018-11-14 Thread Alexandre Belloni
On 14/11/2018 00:36:45+0100, Christophe JAILLET wrote: > In case of error, we return 0. > This is spurious and not consistent with the other functions of the driver. > Commit e115a2bf1426 has modified more than what is said in the commit > message. Reverse part of it znd return an error when needed

Re: [PATCH] rtc: max77686: Fix the returned value in case of error in 'max77686_rtc_read_time()'

2018-11-13 Thread Chanwoo Choi
On 2018년 11월 14일 08:36, Christophe JAILLET wrote: > In case of error, we return 0. > This is spurious and not consistent with the other functions of the driver. > Commit e115a2bf1426 has modified more than what is said in the commit > message. Reverse part of it znd return an error when needed, as

[PATCH] rtc: max77686: Fix the returned value in case of error in 'max77686_rtc_read_time()'

2018-11-13 Thread Christophe JAILLET
In case of error, we return 0. This is spurious and not consistent with the other functions of the driver. Commit e115a2bf1426 has modified more than what is said in the commit message. Reverse part of it znd return an error when needed, as it was previously. Fixes: e115a2bf1426 ("rtc: max77686: s