Re: [PATCH] rtc: rtc-v3020: use gpio_request_one()

2013-02-21 Thread Jingoo Han
On Thursday, February 21, 2013 5:48 PM, Igor Grinberg wrote: > > On 02/21/13 10:31, Jingoo Han wrote: > > Using gpio_request_one() can make the code simpler because it can > > set the direction and initial value in one shot. > > If you are on this, then I think converting to gpio_request_array()

Re: [PATCH] rtc: rtc-v3020: use gpio_request_one()

2013-02-21 Thread Igor Grinberg
On 02/21/13 10:31, Jingoo Han wrote: > Using gpio_request_one() can make the code simpler because it can > set the direction and initial value in one shot. If you are on this, then I think converting to gpio_request_array() would be even better. > > Signed-off-by: Jingoo Han > --- >

[PATCH] rtc: rtc-v3020: use gpio_request_one()

2013-02-21 Thread Jingoo Han
Using gpio_request_one() can make the code simpler because it can set the direction and initial value in one shot. Signed-off-by: Jingoo Han --- drivers/rtc/rtc-v3020.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/rtc/rtc-v3020.c b/drivers/rtc/rtc-v3020.c

[PATCH] rtc: rtc-v3020: use gpio_request_one()

2013-02-21 Thread Jingoo Han
Using gpio_request_one() can make the code simpler because it can set the direction and initial value in one shot. Signed-off-by: Jingoo Han jg1@samsung.com --- drivers/rtc/rtc-v3020.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/rtc/rtc-v3020.c

Re: [PATCH] rtc: rtc-v3020: use gpio_request_one()

2013-02-21 Thread Igor Grinberg
On 02/21/13 10:31, Jingoo Han wrote: Using gpio_request_one() can make the code simpler because it can set the direction and initial value in one shot. If you are on this, then I think converting to gpio_request_array() would be even better. Signed-off-by: Jingoo Han jg1@samsung.com

Re: [PATCH] rtc: rtc-v3020: use gpio_request_one()

2013-02-21 Thread Jingoo Han
On Thursday, February 21, 2013 5:48 PM, Igor Grinberg wrote: On 02/21/13 10:31, Jingoo Han wrote: Using gpio_request_one() can make the code simpler because it can set the direction and initial value in one shot. If you are on this, then I think converting to gpio_request_array() would