Re: [PATCH] rtc: rv3028: add clkout support

2019-10-18 Thread Parthiban Nallathambi
Hi, Thanks for the comments. Will send v2 with changes. On 10/11/19 11:17 AM, Alexandre Belloni wrote: Hi, thanks for the patch, minor comments below. On 27/09/2019 16:15:05+0200, Parthiban Nallathambi wrote: + ret = regmap_update_bits(rv3028->regmap, RV3028_STATUS, +

Re: [PATCH] rtc: rv3028: add clkout support

2019-10-11 Thread Alexandre Belloni
Hi, thanks for the patch, minor comments below. On 27/09/2019 16:15:05+0200, Parthiban Nallathambi wrote: > + ret = regmap_update_bits(rv3028->regmap, RV3028_STATUS, > + RV3028_STATUS_CLKF, 0); > + if (ret < 0) > + return ret; > + This is already

[PATCH] rtc: rv3028: add clkout support

2019-09-27 Thread Parthiban Nallathambi
rv3028 provides clkout (enabled by default). Add clkout to clock framework source and control from device tree for variable frequency with enable and disable functionality. Signed-off-by: Parthiban Nallathambi --- drivers/rtc/rtc-rv3028.c | 156 +++ 1 file