Re: [PATCH] rtc: rv8803: Check return value of rv8803_write_reg

2018-12-27 Thread Alexandre Belloni
On 27/12/2018 17:28:33-0600, Kangjie Lu wrote: > On Thu, Dec 27, 2018 at 4:31 PM Heiner Kallweit > wrote: > > > On 27.12.2018 21:28, Aditya Pakki wrote: > > > In rv8803_handle_irq, rv8803_write_reg can return a failed return > > > value when attempting to write to the bus. The fix checks the

Re: [PATCH] rtc: rv8803: Check return value of rv8803_write_reg

2018-12-27 Thread Alexandre Belloni
On 27/12/2018 14:28:55-0600, Aditya Pakki wrote: > In rv8803_handle_irq, rv8803_write_reg can return a failed return > value when attempting to write to the bus. The fix checks the output > and throws a dev_warn notifying of the failure. > Is there any point in doing that as the error will self

Re: [PATCH] rtc: rv8803: Check return value of rv8803_write_reg

2018-12-27 Thread Heiner Kallweit
On 28.12.2018 00:28, Kangjie Lu wrote: > > > On Thu, Dec 27, 2018 at 4:31 PM Heiner Kallweit > wrote: > > On 27.12.2018 21:28, Aditya Pakki wrote: > > In rv8803_handle_irq, rv8803_write_reg can return a failed return > > value when attempting to write

Re: [PATCH] rtc: rv8803: Check return value of rv8803_write_reg

2018-12-27 Thread Heiner Kallweit
On 27.12.2018 21:28, Aditya Pakki wrote: > In rv8803_handle_irq, rv8803_write_reg can return a failed return > value when attempting to write to the bus. The fix checks the output > and throws a dev_warn notifying of the failure. > > Signed-off-by: Aditya Pakki > --- > drivers/rtc/rtc-rv8803.c

[PATCH] rtc: rv8803: Check return value of rv8803_write_reg

2018-12-27 Thread Aditya Pakki
In rv8803_handle_irq, rv8803_write_reg can return a failed return value when attempting to write to the bus. The fix checks the output and throws a dev_warn notifying of the failure. Signed-off-by: Aditya Pakki --- drivers/rtc/rtc-rv8803.c | 9 +++-- 1 file changed, 7 insertions(+), 2