Re: [PATCH] rtc: wilco-ec: Sanitize values received from RTC

2019-09-16 Thread Nick Crews
On Mon, Sep 16, 2019 at 2:02 AM Alexandre Belloni wrote: > > On 15/09/2019 23:44:03+0100, Nick Crews wrote: > > Hi Alexandre, thanks for the thoughts. > > > > On Thu, Sep 12, 2019 at 9:09 AM Alexandre Belloni > > wrote: > > > > > > Hi Nick, > > > > > > On 10/09/2019 16:19:29+0100, Nick Crews

Re: [PATCH] rtc: wilco-ec: Sanitize values received from RTC

2019-09-16 Thread Alexandre Belloni
On 15/09/2019 23:44:03+0100, Nick Crews wrote: > Hi Alexandre, thanks for the thoughts. > > On Thu, Sep 12, 2019 at 9:09 AM Alexandre Belloni > wrote: > > > > Hi Nick, > > > > On 10/09/2019 16:19:29+0100, Nick Crews wrote: > > > Check that the time received from the RTC HW is valid, > > >

Re: [PATCH] rtc: wilco-ec: Sanitize values received from RTC

2019-09-15 Thread Nick Crews
Hi Alexandre, thanks for the thoughts. On Thu, Sep 12, 2019 at 9:09 AM Alexandre Belloni wrote: > > Hi Nick, > > On 10/09/2019 16:19:29+0100, Nick Crews wrote: > > Check that the time received from the RTC HW is valid, > > otherwise the computation of rtc_year_days() in the next > > line could,

Re: [PATCH] rtc: wilco-ec: Sanitize values received from RTC

2019-09-12 Thread Alexandre Belloni
Hi Nick, On 10/09/2019 16:19:29+0100, Nick Crews wrote: > Check that the time received from the RTC HW is valid, > otherwise the computation of rtc_year_days() in the next > line could, and sometimes does, crash the kernel. > > While we're at it, fix the license to plain "GPL". > >

[PATCH] rtc: wilco-ec: Sanitize values received from RTC

2019-09-10 Thread Nick Crews
Check that the time received from the RTC HW is valid, otherwise the computation of rtc_year_days() in the next line could, and sometimes does, crash the kernel. While we're at it, fix the license to plain "GPL". Signed-off-by: Nick Crews --- drivers/rtc/rtc-wilco-ec.c | 12 ++-- 1