Re: [PATCH] rtl8187: fix use after free on failure path in rtl8187_probe()

2014-04-07 Thread Hin-Tak Leung
-- On Sun, Mar 30, 2014 10:31 PM BST Larry Finger wrote: >On 03/28/2014 03:26 PM, Alexey Khoroshilov wrote: > If allocation of io_dmabuf fails, rtl8187_probe() calls usb_put_dev(udev) > while usb_get_dev(udev) is not called yet. As a result refcnt is decremented >

Re: [PATCH] rtl8187: fix use after free on failure path in rtl8187_probe()

2014-04-07 Thread Hin-Tak Leung
-- On Sun, Mar 30, 2014 10:31 PM BST Larry Finger wrote: On 03/28/2014 03:26 PM, Alexey Khoroshilov wrote: If allocation of io_dmabuf fails, rtl8187_probe() calls usb_put_dev(udev) while usb_get_dev(udev) is not called yet. As a result refcnt is decremented

Re: [PATCH] rtl8187: fix use after free on failure path in rtl8187_probe()

2014-03-30 Thread Larry Finger
On 03/28/2014 03:26 PM, Alexey Khoroshilov wrote: If allocation of io_dmabuf fails, rtl8187_probe() calls usb_put_dev(udev) while usb_get_dev(udev) is not called yet. As a result refcnt is decremented incorrectly and usb_dev can be used after memory deallocation. Found by Linux Driver

Re: [PATCH] rtl8187: fix use after free on failure path in rtl8187_probe()

2014-03-30 Thread Larry Finger
On 03/28/2014 03:26 PM, Alexey Khoroshilov wrote: If allocation of io_dmabuf fails, rtl8187_probe() calls usb_put_dev(udev) while usb_get_dev(udev) is not called yet. As a result refcnt is decremented incorrectly and usb_dev can be used after memory deallocation. Found by Linux Driver

[PATCH] rtl8187: fix use after free on failure path in rtl8187_probe()

2014-03-28 Thread Alexey Khoroshilov
If allocation of io_dmabuf fails, rtl8187_probe() calls usb_put_dev(udev) while usb_get_dev(udev) is not called yet. As a result refcnt is decremented incorrectly and usb_dev can be used after memory deallocation. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by:

[PATCH] rtl8187: fix use after free on failure path in rtl8187_probe()

2014-03-28 Thread Alexey Khoroshilov
If allocation of io_dmabuf fails, rtl8187_probe() calls usb_put_dev(udev) while usb_get_dev(udev) is not called yet. As a result refcnt is decremented incorrectly and usb_dev can be used after memory deallocation. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: