Re: [PATCH] rtl8188eu: Correcting macro ROUND macro defination

2017-03-14 Thread Dan Carpenter
I don't understand why we have any of these things under the /* AES tables*/ comment. They don't seem to be used anywhere. Can't we just delete them? regards, dan carpenter

Re: [PATCH] rtl8188eu: Correcting macro ROUND macro defination

2017-03-14 Thread Pushkar Jambhlekar
Your concerns were valid. Since 'do' is defined on the new-line, git did not include it in diff. On Tue, Mar 14, 2017 at 5:22 PM, Alexander Kapshuk wrote: > On Tue, Mar 14, 2017 at 1:44 PM, Pushkar Jambhlekar > wrote: >> Hi Alexander, >> >> It is not needed for a macro. I am modifying do---while

Re: [PATCH] rtl8188eu: Correcting macro ROUND macro defination

2017-03-14 Thread Alexander Kapshuk
On Tue, Mar 14, 2017 at 1:44 PM, Pushkar Jambhlekar wrote: > Hi Alexander, > > It is not needed for a macro. I am modifying do---while() loop for ROUND > macro. > > /** > * Expand the cipher key into the encryption key schedule. > * > * @return the number of rounds for the given cipher ke

Re: [PATCH] rtl8188eu: Correcting macro ROUND macro defination

2017-03-14 Thread Pushkar Jambhlekar
Hi Alexander, It is not needed for a macro. I am modifying do---while() loop for ROUND macro. /** * Expand the cipher key into the encryption key schedule. * * @return the number of rounds for the given cipher key size. */ #define ROUND(i, d, s) \ do {

Re: [PATCH] rtl8188eu: Correcting macro ROUND macro defination

2017-03-14 Thread Alexander Kapshuk
On Tue, Mar 14, 2017 at 1:26 PM, Pushkar Jambhlekar wrote: > Description: > There should not be ';' after do ... while(0) in macro defination > > Signed-off-by: Pushkar Jambhlekar > --- > drivers/staging/rtl8188eu/core/rtw_security.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

[PATCH] rtl8188eu: Correcting macro ROUND macro defination

2017-03-14 Thread Pushkar Jambhlekar
Description: There should not be ';' after do ... while(0) in macro defination Signed-off-by: Pushkar Jambhlekar --- drivers/staging/rtl8188eu/core/rtw_security.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_security.c b/drivers/stag