Re: [PATCH] rtlwifi/rtl8192de: remove redundant else if check

2015-01-13 Thread Larry Finger
On 01/13/2015 08:07 AM, Colin King wrote: From: Colin Ian King The else if check condition checks for the opposite of the if check, hence the else if check is redundant and can be replaced with a simple else: if (rtlpriv->rtlhal.macphymode == SINGLEMAC_SINGLEPHY) { .. } else if

[PATCH] rtlwifi/rtl8192de: remove redundant else if check

2015-01-13 Thread Colin King
From: Colin Ian King The else if check condition checks for the opposite of the if check, hence the else if check is redundant and can be replaced with a simple else: if (rtlpriv->rtlhal.macphymode == SINGLEMAC_SINGLEPHY) { .. } else if (rtlpriv->rtlhal.macphymode !=

Re: [PATCH] rtlwifi/rtl8192de: remove redundant else if check

2015-01-13 Thread Larry Finger
On 01/13/2015 08:07 AM, Colin King wrote: From: Colin Ian King colin.k...@canonical.com The else if check condition checks for the opposite of the if check, hence the else if check is redundant and can be replaced with a simple else: if (rtlpriv-rtlhal.macphymode == SINGLEMAC_SINGLEPHY) {

[PATCH] rtlwifi/rtl8192de: remove redundant else if check

2015-01-13 Thread Colin King
From: Colin Ian King colin.k...@canonical.com The else if check condition checks for the opposite of the if check, hence the else if check is redundant and can be replaced with a simple else: if (rtlpriv-rtlhal.macphymode == SINGLEMAC_SINGLEPHY) { .. } else if (rtlpriv-rtlhal.macphymode