Re: [PATCH] rtlwifi: pass struct rtl_stats by reference as it is more efficient

2016-02-22 Thread Alexander Stein
On Monday 22 February 2016 10:16:20, Colin Ian King wrote: > On 22/02/16 06:51, Alexander Stein wrote: > > On Saturday 20 February 2016 22:10:27, Colin King wrote: > >> From: Colin Ian King > >> > >> passing rtl_stats by value is inefficient; the structure is over 300 >

Re: [PATCH] rtlwifi: pass struct rtl_stats by reference as it is more efficient

2016-02-22 Thread Alexander Stein
On Monday 22 February 2016 10:16:20, Colin Ian King wrote: > On 22/02/16 06:51, Alexander Stein wrote: > > On Saturday 20 February 2016 22:10:27, Colin King wrote: > >> From: Colin Ian King > >> > >> passing rtl_stats by value is inefficient; the structure is over 300 > >> bytes in size and

Re: [PATCH] rtlwifi: pass struct rtl_stats by reference as it is more efficient

2016-02-22 Thread Colin Ian King
On 22/02/16 06:51, Alexander Stein wrote: > On Saturday 20 February 2016 22:10:27, Colin King wrote: >> From: Colin Ian King >> >> passing rtl_stats by value is inefficient; the structure is over 300 >> bytes in size and generally just one field (packet_report_type) >>

Re: [PATCH] rtlwifi: pass struct rtl_stats by reference as it is more efficient

2016-02-22 Thread Colin Ian King
On 22/02/16 06:51, Alexander Stein wrote: > On Saturday 20 February 2016 22:10:27, Colin King wrote: >> From: Colin Ian King >> >> passing rtl_stats by value is inefficient; the structure is over 300 >> bytes in size and generally just one field (packet_report_type) >> is being accessed, so the

Re: [PATCH] rtlwifi: pass struct rtl_stats by reference as it is more efficient

2016-02-21 Thread Alexander Stein
On Saturday 20 February 2016 22:10:27, Colin King wrote: > From: Colin Ian King > > passing rtl_stats by value is inefficient; the structure is over 300 > bytes in size and generally just one field (packet_report_type) > is being accessed, so the pass by value is a

Re: [PATCH] rtlwifi: pass struct rtl_stats by reference as it is more efficient

2016-02-21 Thread Alexander Stein
On Saturday 20 February 2016 22:10:27, Colin King wrote: > From: Colin Ian King > > passing rtl_stats by value is inefficient; the structure is over 300 > bytes in size and generally just one field (packet_report_type) > is being accessed, so the pass by value is a relatively large overhead. >

[PATCH] rtlwifi: pass struct rtl_stats by reference as it is more efficient

2016-02-20 Thread Colin King
From: Colin Ian King passing rtl_stats by value is inefficient; the structure is over 300 bytes in size and generally just one field (packet_report_type) is being accessed, so the pass by value is a relatively large overhead. This change just affects just the

[PATCH] rtlwifi: pass struct rtl_stats by reference as it is more efficient

2016-02-20 Thread Colin King
From: Colin Ian King passing rtl_stats by value is inefficient; the structure is over 300 bytes in size and generally just one field (packet_report_type) is being accessed, so the pass by value is a relatively large overhead. This change just affects just the rx_command_packet calls.