Re: [PATCH] scatterlist: add a warning if sg_virt() is used on highmem pages

2012-12-06 Thread Sebastian Andrzej Siewior
On 12/05/2012 10:46 PM, Andrew Morton wrote: --- a/include/linux/scatterlist.h +++ b/include/linux/scatterlist.h @@ -198,6 +198,9 @@ static inline dma_addr_t sg_phys(struct scatterlist *sg) **/ static inline void *sg_virt(struct scatterlist *sg) { +#ifdef CONFIG_DEBUG_SG +

Re: [PATCH] scatterlist: add a warning if sg_virt() is used on highmem pages

2012-12-06 Thread Sebastian Andrzej Siewior
On 12/05/2012 10:46 PM, Andrew Morton wrote: --- a/include/linux/scatterlist.h +++ b/include/linux/scatterlist.h @@ -198,6 +198,9 @@ static inline dma_addr_t sg_phys(struct scatterlist *sg) **/ static inline void *sg_virt(struct scatterlist *sg) { +#ifdef CONFIG_DEBUG_SG +

Re: [PATCH] scatterlist: add a warning if sg_virt() is used on highmem pages

2012-12-05 Thread Andrew Morton
On Wed, 5 Dec 2012 12:28:18 +0100 Sebastian Andrzej Siewior wrote: > sg_virt() on highmem pages won't work. This WARN_ON() should catch some > that still try. > > Signed-off-by: Sebastian Andrzej Siewior > --- > include/linux/scatterlist.h |3 +++ > 1 file changed, 3 insertions(+) > >

[PATCH] scatterlist: add a warning if sg_virt() is used on highmem pages

2012-12-05 Thread Sebastian Andrzej Siewior
sg_virt() on highmem pages won't work. This WARN_ON() should catch some that still try. Signed-off-by: Sebastian Andrzej Siewior --- include/linux/scatterlist.h |3 +++ 1 file changed, 3 insertions(+) diff --git a/include/linux/scatterlist.h b/include/linux/scatterlist.h index

[PATCH] scatterlist: add a warning if sg_virt() is used on highmem pages

2012-12-05 Thread Sebastian Andrzej Siewior
sg_virt() on highmem pages won't work. This WARN_ON() should catch some that still try. Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- include/linux/scatterlist.h |3 +++ 1 file changed, 3 insertions(+) diff --git a/include/linux/scatterlist.h

Re: [PATCH] scatterlist: add a warning if sg_virt() is used on highmem pages

2012-12-05 Thread Andrew Morton
On Wed, 5 Dec 2012 12:28:18 +0100 Sebastian Andrzej Siewior bige...@linutronix.de wrote: sg_virt() on highmem pages won't work. This WARN_ON() should catch some that still try. Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- include/linux/scatterlist.h |3 +++ 1