Re: [PATCH] sched/core: add __sched tag for io_schedule()

2019-06-03 Thread Gao Xiang
Hi Peter, On 2019/6/3 16:58, Peter Zijlstra wrote: > On Fri, May 31, 2019 at 04:29:12PM +0800, Gao Xiang wrote: >> non-inline io_schedule() was introduced in >> commit 10ab56434f2f ("sched/core: Separate out io_schedule_prepare() and >> io_schedule_finish()") >> Keep in line with

Re: [PATCH] sched/core: add __sched tag for io_schedule()

2019-06-03 Thread Peter Zijlstra
On Fri, May 31, 2019 at 04:29:12PM +0800, Gao Xiang wrote: > non-inline io_schedule() was introduced in > commit 10ab56434f2f ("sched/core: Separate out io_schedule_prepare() and > io_schedule_finish()") > Keep in line with io_schedule_timeout, Otherwise > "/proc//wchan" will report io_schedule()

Re: [PATCH] sched/core: add __sched tag for io_schedule()

2019-06-02 Thread Gao Xiang
On 2019/5/31 22:37, Tejun Heo wrote: > On Fri, May 31, 2019 at 04:29:12PM +0800, Gao Xiang wrote: >> non-inline io_schedule() was introduced in >> commit 10ab56434f2f ("sched/core: Separate out io_schedule_prepare() and >> io_schedule_finish()") >> Keep in line with io_schedule_timeout,

Re: [PATCH] sched/core: add __sched tag for io_schedule()

2019-05-31 Thread Tejun Heo
On Fri, May 31, 2019 at 04:29:12PM +0800, Gao Xiang wrote: > non-inline io_schedule() was introduced in > commit 10ab56434f2f ("sched/core: Separate out io_schedule_prepare() and > io_schedule_finish()") > Keep in line with io_schedule_timeout, Otherwise > "/proc//wchan" will report io_schedule()

[PATCH] sched/core: add __sched tag for io_schedule()

2019-05-31 Thread Gao Xiang
non-inline io_schedule() was introduced in commit 10ab56434f2f ("sched/core: Separate out io_schedule_prepare() and io_schedule_finish()") Keep in line with io_schedule_timeout, Otherwise "/proc//wchan" will report io_schedule() rather than its callers when waiting io. Reported-by: Jilong Kou