On Fri, Apr 20, 2018 at 11:29:33PM +0200, Lukas Bulwahn wrote:
>
> On Fri, 20 Apr 2018, Peter Zijlstra wrote:
>
> > On Fri, Apr 20, 2018 at 06:29:07PM +0200, Philipp Klocke wrote:
> > > The gain is stopping a warning that clutters the output log of clang.
> >
> > Well, you should not be using
On Fri, Apr 20, 2018 at 11:29:33PM +0200, Lukas Bulwahn wrote:
>
> On Fri, 20 Apr 2018, Peter Zijlstra wrote:
>
> > On Fri, Apr 20, 2018 at 06:29:07PM +0200, Philipp Klocke wrote:
> > > The gain is stopping a warning that clutters the output log of clang.
> >
> > Well, you should not be using
On Fri, 20 Apr 2018, Peter Zijlstra wrote:
> On Fri, Apr 20, 2018 at 06:29:07PM +0200, Philipp Klocke wrote:
> > The gain is stopping a warning that clutters the output log of clang.
>
> Well, you should not be using clang anyway. It is known to miscompile
> the kernel.
>
There are some
On Fri, 20 Apr 2018, Peter Zijlstra wrote:
> On Fri, Apr 20, 2018 at 06:29:07PM +0200, Philipp Klocke wrote:
> > The gain is stopping a warning that clutters the output log of clang.
>
> Well, you should not be using clang anyway. It is known to miscompile
> the kernel.
>
There are some
On Fri, Apr 20, 2018 at 06:29:07PM +0200, Philipp Klocke wrote:
> The gain is stopping a warning that clutters the output log of clang.
Well, you should not be using clang anyway. It is known to miscompile
the kernel.
> To improve readability, one can drop the ifdef-structure and just keep
> the
On Fri, Apr 20, 2018 at 06:29:07PM +0200, Philipp Klocke wrote:
> The gain is stopping a warning that clutters the output log of clang.
Well, you should not be using clang anyway. It is known to miscompile
the kernel.
> To improve readability, one can drop the ifdef-structure and just keep
> the
On 20.04.2018 09:57, Peter Zijlstra wrote:
> On Mon, Apr 16, 2018 at 10:54:26AM +0200, Philipp Klocke wrote:
>
>> This patch is motivated by the clang warning Wconstant-logical-operand,
>> issued when logically comparing a variable to a constant integer that is
>> neither 1 nor 0. It happens for
On 20.04.2018 09:57, Peter Zijlstra wrote:
> On Mon, Apr 16, 2018 at 10:54:26AM +0200, Philipp Klocke wrote:
>
>> This patch is motivated by the clang warning Wconstant-logical-operand,
>> issued when logically comparing a variable to a constant integer that is
>> neither 1 nor 0. It happens for
Also, please don't cross-post with moderated lists, that's just
annoying.
Also, please don't cross-post with moderated lists, that's just
annoying.
On Mon, Apr 16, 2018 at 10:54:26AM +0200, Philipp Klocke wrote:
> This patch is motivated by the clang warning Wconstant-logical-operand,
> issued when logically comparing a variable to a constant integer that is
> neither 1 nor 0. It happens for sched_feat(x) when sysctl_sched_features
> is
On Mon, Apr 16, 2018 at 10:54:26AM +0200, Philipp Klocke wrote:
> This patch is motivated by the clang warning Wconstant-logical-operand,
> issued when logically comparing a variable to a constant integer that is
> neither 1 nor 0. It happens for sched_feat(x) when sysctl_sched_features
> is
On Mon, Apr 16, 2018 at 10:54:26AM +0200, Philipp Klocke wrote:
> Make sched_feat(x) return 1 or 0 instead of 2**x or 0 when
> sysctl_sched_features is constant, by changing the left shift of the
> mask-bit to a right shift of the bitmap. The behaviour of the code
> remains unchanged.
> We prove
On Mon, Apr 16, 2018 at 10:54:26AM +0200, Philipp Klocke wrote:
> Make sched_feat(x) return 1 or 0 instead of 2**x or 0 when
> sysctl_sched_features is constant, by changing the left shift of the
> mask-bit to a right shift of the bitmap. The behaviour of the code
> remains unchanged.
> We prove
Make sched_feat(x) return 1 or 0 instead of 2**x or 0 when
sysctl_sched_features is constant, by changing the left shift of the
mask-bit to a right shift of the bitmap. The behaviour of the code
remains unchanged.
We prove this by showing that the compiler can evaluate this shift
during compile
Make sched_feat(x) return 1 or 0 instead of 2**x or 0 when
sysctl_sched_features is constant, by changing the left shift of the
mask-bit to a right shift of the bitmap. The behaviour of the code
remains unchanged.
We prove this by showing that the compiler can evaluate this shift
during compile
16 matches
Mail list logo
