Re: [PATCH] sched/fair: Fix ftq noise bench regression

2017-03-22 Thread Dietmar Eggemann
On 22/03/17 16:55, Vincent Guittot wrote: > On 22 March 2017 at 17:22, Dietmar Eggemann wrote: >> On 22/03/17 09:22, Vincent Guittot wrote: >>> On 21 March 2017 at 18:46, Dietmar Eggemann >>> wrote: Hi Vincent, On 17/03/17

Re: [PATCH] sched/fair: Fix ftq noise bench regression

2017-03-22 Thread Dietmar Eggemann
On 22/03/17 16:55, Vincent Guittot wrote: > On 22 March 2017 at 17:22, Dietmar Eggemann wrote: >> On 22/03/17 09:22, Vincent Guittot wrote: >>> On 21 March 2017 at 18:46, Dietmar Eggemann >>> wrote: Hi Vincent, On 17/03/17 13:47, Vincent Guittot wrote: [...] >> +static inline

Re: [PATCH] sched/fair: Fix ftq noise bench regression

2017-03-22 Thread Vincent Guittot
On 22 March 2017 at 17:22, Dietmar Eggemann wrote: > On 22/03/17 09:22, Vincent Guittot wrote: >> On 21 March 2017 at 18:46, Dietmar Eggemann wrote: >>> Hi Vincent, >>> >>> On 17/03/17 13:47, Vincent Guittot wrote: >>> >>> [...] >>>

Re: [PATCH] sched/fair: Fix ftq noise bench regression

2017-03-22 Thread Vincent Guittot
On 22 March 2017 at 17:22, Dietmar Eggemann wrote: > On 22/03/17 09:22, Vincent Guittot wrote: >> On 21 March 2017 at 18:46, Dietmar Eggemann wrote: >>> Hi Vincent, >>> >>> On 17/03/17 13:47, Vincent Guittot wrote: >>> >>> [...] >>> Reported-by: ying.hu...@linux.intel.com

Re: [PATCH] sched/fair: Fix ftq noise bench regression

2017-03-22 Thread Dietmar Eggemann
On 22/03/17 09:22, Vincent Guittot wrote: > On 21 March 2017 at 18:46, Dietmar Eggemann wrote: >> Hi Vincent, >> >> On 17/03/17 13:47, Vincent Guittot wrote: >> >> [...] >> >>> Reported-by: ying.hu...@linux.intel.com >>> Signed-off-by: Vincent Guittot

Re: [PATCH] sched/fair: Fix ftq noise bench regression

2017-03-22 Thread Dietmar Eggemann
On 22/03/17 09:22, Vincent Guittot wrote: > On 21 March 2017 at 18:46, Dietmar Eggemann wrote: >> Hi Vincent, >> >> On 17/03/17 13:47, Vincent Guittot wrote: >> >> [...] >> >>> Reported-by: ying.hu...@linux.intel.com >>> Signed-off-by: Vincent Guittot >>> Fixes: 4e5160766fcc ("sched/fair:

Re: [PATCH] sched/fair: Fix ftq noise bench regression

2017-03-22 Thread Vincent Guittot
On 21 March 2017 at 18:46, Dietmar Eggemann wrote: > Hi Vincent, > > On 17/03/17 13:47, Vincent Guittot wrote: > > [...] > >> Reported-by: ying.hu...@linux.intel.com >> Signed-off-by: Vincent Guittot >> Fixes: 4e5160766fcc ("sched/fair:

Re: [PATCH] sched/fair: Fix ftq noise bench regression

2017-03-22 Thread Vincent Guittot
On 21 March 2017 at 18:46, Dietmar Eggemann wrote: > Hi Vincent, > > On 17/03/17 13:47, Vincent Guittot wrote: > > [...] > >> Reported-by: ying.hu...@linux.intel.com >> Signed-off-by: Vincent Guittot >> Fixes: 4e5160766fcc ("sched/fair: Propagate asynchrous detach") > > I thought I can see a

Re: [PATCH] sched/fair: Fix ftq noise bench regression

2017-03-21 Thread Dietmar Eggemann
Hi Vincent, On 17/03/17 13:47, Vincent Guittot wrote: [...] > Reported-by: ying.hu...@linux.intel.com > Signed-off-by: Vincent Guittot > Fixes: 4e5160766fcc ("sched/fair: Propagate asynchrous detach") I thought I can see a difference by running: perf stat --null

Re: [PATCH] sched/fair: Fix ftq noise bench regression

2017-03-21 Thread Dietmar Eggemann
Hi Vincent, On 17/03/17 13:47, Vincent Guittot wrote: [...] > Reported-by: ying.hu...@linux.intel.com > Signed-off-by: Vincent Guittot > Fixes: 4e5160766fcc ("sched/fair: Propagate asynchrous detach") I thought I can see a difference by running: perf stat --null --repeat 10 -- perf bench

[PATCH] sched/fair: Fix ftq noise bench regression

2017-03-17 Thread Vincent Guittot
A regression of the ftq noise has been reported by ying.hu...@linux.intel.com on 8 threads Intel(R) Core(TM)i7-4770 CPU @ 3.40GHz with 8G memory due to commit 4e5160766fcc ("sched/fair: Propagate asynchrous detach") The only part of the patch that can increase the noise is the update of

[PATCH] sched/fair: Fix ftq noise bench regression

2017-03-17 Thread Vincent Guittot
A regression of the ftq noise has been reported by ying.hu...@linux.intel.com on 8 threads Intel(R) Core(TM)i7-4770 CPU @ 3.40GHz with 8G memory due to commit 4e5160766fcc ("sched/fair: Propagate asynchrous detach") The only part of the patch that can increase the noise is the update of