Re: [PATCH] sched/fair: Remove the duplicate check from group_has_capacity()

2020-08-11 Thread Qi Zheng
On 2020/8/12 上午4:16, Valentin Schneider wrote: On 11/08/20 14:12, Qi Zheng wrote: On 2020/8/11 下午8:48, Valentin Schneider wrote: On 11/08/20 12:44, Qi Zheng wrote: In fact, at the beginning, I added unlikely() here to hint the compiler: - if ((sgs->group_capacity * imbalance_pct) < -

Re: [PATCH] sched/fair: Remove the duplicate check from group_has_capacity()

2020-08-11 Thread Valentin Schneider
On 11/08/20 14:12, Qi Zheng wrote: > On 2020/8/11 下午8:48, Valentin Schneider wrote: >> On 11/08/20 12:44, Qi Zheng wrote: >>> In fact, at the beginning, I added unlikely() here to hint the compiler: >>> >>> - if ((sgs->group_capacity * imbalance_pct) < >>> -

Re: [PATCH] sched/fair: Remove the duplicate check from group_has_capacity()

2020-08-11 Thread Qi Zheng
On 2020/8/11 下午8:48, Valentin Schneider wrote: On 11/08/20 12:44, Qi Zheng wrote: On 2020/8/11 下午6:38, Valentin Schneider wrote: On 11/08/20 04:39, Qi Zheng wrote: On 2020/8/11 上午2:33, Valentin Schneider wrote: On 10/08/20 02:00, Qi Zheng wrote: 1. The group_has_capacity() function is

Re: [PATCH] sched/fair: Remove the duplicate check from group_has_capacity()

2020-08-11 Thread Valentin Schneider
On 11/08/20 12:44, Qi Zheng wrote: > On 2020/8/11 下午6:38, Valentin Schneider wrote: >> >> On 11/08/20 04:39, Qi Zheng wrote: >>> On 2020/8/11 上午2:33, Valentin Schneider wrote: On 10/08/20 02:00, Qi Zheng wrote: > 1. The group_has_capacity() function is only called in >

Re: [PATCH] sched/fair: Remove the duplicate check from group_has_capacity()

2020-08-11 Thread Qi Zheng
On 2020/8/11 下午6:38, Valentin Schneider wrote: On 11/08/20 04:39, Qi Zheng wrote: On 2020/8/11 上午2:33, Valentin Schneider wrote: On 10/08/20 02:00, Qi Zheng wrote: 1. The group_has_capacity() function is only called in group_classify(). 2. The following inequality has already been

Re: [PATCH] sched/fair: Remove the duplicate check from group_has_capacity()

2020-08-11 Thread Valentin Schneider
On 11/08/20 04:39, Qi Zheng wrote: > On 2020/8/11 上午2:33, Valentin Schneider wrote: >> >> On 10/08/20 02:00, Qi Zheng wrote: >>> 1. The group_has_capacity() function is only called in >>> group_classify(). >>> 2. The following inequality has already been checked in >>>

Re: [PATCH] sched/fair: Remove the duplicate check from group_has_capacity()

2020-08-10 Thread Qi Zheng
On 2020/8/11 上午2:33, Valentin Schneider wrote: On 10/08/20 02:00, Qi Zheng wrote: 1. The group_has_capacity() function is only called in group_classify(). 2. The following inequality has already been checked in group_is_overloaded() which was also called in group_classify().

Re: [PATCH] sched/fair: Remove the duplicate check from group_has_capacity()

2020-08-10 Thread Valentin Schneider
On 10/08/20 02:00, Qi Zheng wrote: > 1. The group_has_capacity() function is only called in >group_classify(). > 2. The following inequality has already been checked in >group_is_overloaded() which was also called in >group_classify(). > > (sgs->group_capacity * imbalance_pct)

[PATCH] sched/fair: Remove the duplicate check from group_has_capacity()

2020-08-09 Thread Qi Zheng
1. The group_has_capacity() function is only called in group_classify(). 2. The following inequality has already been checked in group_is_overloaded() which was also called in group_classify(). (sgs->group_capacity * imbalance_pct) < (sgs->group_runnable *