Re: [PATCH] sched/fair: fix update the nohz.next_balance even if we haven't done any load balance

2015-03-27 Thread Preeti U Murthy
Hi Wanpeng, On 03/27/2015 12:55 PM, Wanpeng Li wrote: > As Srikar pointed out (https://lkml.org/lkml/2015/3/27/26): > > | With the current code when the ilb cpus are not free: > | - We would be updating the nohz.next_balance even through we havent done > | any load balance. > | - We might

Re: [PATCH] sched/fair: fix update the nohz.next_balance even if we haven't done any load balance

2015-03-27 Thread Wanpeng Li
On Fri, Mar 27, 2015 at 12:58:22AM -0700, Jason Low wrote: >On Fri, 2015-03-27 at 15:25 +0800, Wanpeng Li wrote: >> As Srikar pointed out (https://lkml.org/lkml/2015/3/27/26): >> >> | With the current code when the ilb cpus are not free: >> | - We would be updating the nohz.next_balance even

Re: [PATCH] sched/fair: fix update the nohz.next_balance even if we haven't done any load balance

2015-03-27 Thread Jason Low
On Fri, 2015-03-27 at 15:25 +0800, Wanpeng Li wrote: > As Srikar pointed out (https://lkml.org/lkml/2015/3/27/26): > > | With the current code when the ilb cpus are not free: > | - We would be updating the nohz.next_balance even through we havent done > | any load balance. > | - We might

[PATCH] sched/fair: fix update the nohz.next_balance even if we haven't done any load balance

2015-03-27 Thread Wanpeng Li
As Srikar pointed out (https://lkml.org/lkml/2015/3/27/26): | With the current code when the ilb cpus are not free: | - We would be updating the nohz.next_balance even through we havent done | any load balance. | - We might iterate thro the nohz.idle_cpus_mask()s to find balance_cpus. This

Re: [PATCH] sched/fair: fix update the nohz.next_balance even if we haven't done any load balance

2015-03-27 Thread Wanpeng Li
On Fri, Mar 27, 2015 at 12:58:22AM -0700, Jason Low wrote: On Fri, 2015-03-27 at 15:25 +0800, Wanpeng Li wrote: As Srikar pointed out (https://lkml.org/lkml/2015/3/27/26): | With the current code when the ilb cpus are not free: | - We would be updating the nohz.next_balance even through we

[PATCH] sched/fair: fix update the nohz.next_balance even if we haven't done any load balance

2015-03-27 Thread Wanpeng Li
As Srikar pointed out (https://lkml.org/lkml/2015/3/27/26): | With the current code when the ilb cpus are not free: | - We would be updating the nohz.next_balance even through we havent done | any load balance. | - We might iterate thro the nohz.idle_cpus_mask()s to find balance_cpus. This

Re: [PATCH] sched/fair: fix update the nohz.next_balance even if we haven't done any load balance

2015-03-27 Thread Jason Low
On Fri, 2015-03-27 at 15:25 +0800, Wanpeng Li wrote: As Srikar pointed out (https://lkml.org/lkml/2015/3/27/26): | With the current code when the ilb cpus are not free: | - We would be updating the nohz.next_balance even through we havent done | any load balance. | - We might iterate

Re: [PATCH] sched/fair: fix update the nohz.next_balance even if we haven't done any load balance

2015-03-27 Thread Preeti U Murthy
Hi Wanpeng, On 03/27/2015 12:55 PM, Wanpeng Li wrote: As Srikar pointed out (https://lkml.org/lkml/2015/3/27/26): | With the current code when the ilb cpus are not free: | - We would be updating the nohz.next_balance even through we havent done | any load balance. | - We might iterate