Re: [PATCH] sched/fair: fix use stale overloaded status to find busiest group

2014-11-04 Thread Wanpeng Li
Hi Peter, On 14/11/4 下午6:52, Peter Zijlstra wrote: On Tue, Nov 04, 2014 at 01:30:56PM +0800, Wanpeng Li wrote: Commit caeb178c60f4 ("sched/fair: Make update_sd_pick_busiest() return 'true' on a busier sd") makes groups are ranked in the order overloaded > imbalance > other and busiest group is

Re: [PATCH] sched/fair: fix use stale overloaded status to find busiest group

2014-11-04 Thread Peter Zijlstra
On Tue, Nov 04, 2014 at 01:30:56PM +0800, Wanpeng Li wrote: > Commit caeb178c60f4 ("sched/fair: Make update_sd_pick_busiest() return > 'true' on a busier sd") makes groups are ranked in the order overloaded > > imbalance > other and busiest group is picked according to this order. >

Re: [PATCH] sched/fair: fix use stale overloaded status to find busiest group

2014-11-04 Thread Peter Zijlstra
On Tue, Nov 04, 2014 at 01:30:56PM +0800, Wanpeng Li wrote: Commit caeb178c60f4 (sched/fair: Make update_sd_pick_busiest() return 'true' on a busier sd) makes groups are ranked in the order overloaded imbalance other and busiest group is picked according to this order.

Re: [PATCH] sched/fair: fix use stale overloaded status to find busiest group

2014-11-04 Thread Wanpeng Li
Hi Peter, On 14/11/4 下午6:52, Peter Zijlstra wrote: On Tue, Nov 04, 2014 at 01:30:56PM +0800, Wanpeng Li wrote: Commit caeb178c60f4 (sched/fair: Make update_sd_pick_busiest() return 'true' on a busier sd) makes groups are ranked in the order overloaded imbalance other and busiest group is

[PATCH] sched/fair: fix use stale overloaded status to find busiest group

2014-11-03 Thread Wanpeng Li
Commit caeb178c60f4 ("sched/fair: Make update_sd_pick_busiest() return 'true' on a busier sd") makes groups are ranked in the order overloaded > imbalance > other and busiest group is picked according to this order. sgs->group_capacity_factor is used to check if group is overloaded. In the

[PATCH] sched/fair: fix use stale overloaded status to find busiest group

2014-11-03 Thread Wanpeng Li
Commit caeb178c60f4 (sched/fair: Make update_sd_pick_busiest() return 'true' on a busier sd) makes groups are ranked in the order overloaded imbalance other and busiest group is picked according to this order. sgs-group_capacity_factor is used to check if group is overloaded. In the case of