Re: [PATCH] sched: remove the redundant comments

2021-04-13 Thread Dietmar Eggemann
On 13/04/2021 18:28, Steven Rostedt wrote: > On Tue, 13 Apr 2021 10:36:07 +0200 > Dietmar Eggemann wrote: [...] >> Add a >> >> Fixes: 55627e3cd22c ("sched/core: Remove rq->cpu_load[]") >> >> line. > > It's just removing a comment. Should it really need a "Fixes" tag, which > will cause many

Re: [PATCH] sched: remove the redundant comments

2021-04-13 Thread Steven Rostedt
On Tue, 13 Apr 2021 10:36:07 +0200 Dietmar Eggemann wrote: > > @@ -897,11 +897,6 @@ DECLARE_STATIC_KEY_FALSE(sched_uclamp_used); > > struct rq { > > /* runqueue lock: */ > > raw_spinlock_t lock; > > - > > - /* > > -* nr_running and cpu_load should be in the same cacheline

Re: [PATCH] sched: remove the redundant comments

2021-04-13 Thread Dietmar Eggemann
On 12/04/2021 09:39, Hui Su wrote: > Since the commit 55627e3cd22c ("sched/core: Remove rq->cpu_load[]"), > we don't need this any more. > > Signed-off-by: Hui Su > --- > kernel/sched/sched.h | 5 - > 1 file changed, 5 deletions(-) > > diff --git a/kernel/sched/sched.h

[PATCH] sched: remove the redundant comments

2021-04-12 Thread Hui Su
Since the commit 55627e3cd22c ("sched/core: Remove rq->cpu_load[]"), we don't need this any more. Signed-off-by: Hui Su --- kernel/sched/sched.h | 5 - 1 file changed, 5 deletions(-) diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index 10a1522b1e30..2232022d8561 100644 ---