On 2014-05-13 15:26, Jianyu Zhan wrote:
> Currently, while using ctags to read code, we would get stumbled on
> PageCgroup* symbols: no definition found. And it is quite dull to
> manually dig it out.
>
> This patch adds regular expression replacement pattern for such symbols,
> like what have
On 2014-05-13 15:26, Jianyu Zhan wrote:
Currently, while using ctags to read code, we would get stumbled on
PageCgroup* symbols: no definition found. And it is quite dull to
manually dig it out.
This patch adds regular expression replacement pattern for such symbols,
like what have done for
Hi, Prarit,
>> Currently, no regular expression replacement pattern for PageCgroug*
>
>^^^ *Cgroup*
Sorry for the typo, fixed. Thanks.
>> defined, which causes quite a few pain while reading code. Just get
>> rid of it.
>>
>
>IMO the patch looks fine but can you fixup your changelog a
Hi, Prarit,
Currently, no regular expression replacement pattern for PageCgroug*
^^^ *Cgroup*
Sorry for the typo, fixed. Thanks.
defined, which causes quite a few pain while reading code. Just get
rid of it.
IMO the patch looks fine but can you fixup your changelog a little bit? I
Hi, Marek.
> It does not look like new macros are being defined here on a weekly basis...
Hmm, I think so. I've removed this comment.
> Please do not interleave the new defines with the
> defines.
Ok.
Here is the renewed patch:
---
Currently, no regular expression replacement pattern
Hi, Marek.
It does not look like new macros are being defined here on a weekly basis...
Hmm, I think so. I've removed this comment.
Please do not interleave the new defines with the linux/page-flags.h
defines.
Ok.
Here is the renewed patch:
---
Currently, no regular expression
Dne 10.4.2014 14:58, Jianyu Zhan napsal(a):
> Sorry, the comment in previous patch is somewhat misguiding, this patch
> replaces that one.
>
> Currently, no regular expression replacement patterns for PageCgroup*
> flag-ops are defined, which causes quite a few pain while reading code.
> Just
Dne 10.4.2014 14:58, Jianyu Zhan napsal(a):
Sorry, the comment in previous patch is somewhat misguiding, this patch
replaces that one.
Currently, no regular expression replacement patterns for PageCgroup*
flag-ops are defined, which causes quite a few pain while reading code.
Just get rid
Sorry, the comment in previous patch is somewhat misguiding, this patch
replaces that one.
Currently, no regular expression replacement patterns for PageCgroup*
flag-ops are defined, which causes quite a few pain while reading code.
Just get rid of it.
Also, add a comment to inform people to
Currently, no regular expression replacement pattern for PageCgroug*
defined, which causes quite a few pain while reading code. Just get
rid of it.
Also, add a comment to inform people to add pattern for whatever new
flags they add.
Signed-off-by: Jianyu Zhan
---
include/linux/page_cgroup.h |
Currently, no regular expression replacement pattern for PageCgroug*
defined, which causes quite a few pain while reading code. Just get
rid of it.
Also, add a comment to inform people to add pattern for whatever new
flags they add.
Signed-off-by: Jianyu Zhan nasa4...@gmail.com
---
Sorry, the comment in previous patch is somewhat misguiding, this patch
replaces that one.
Currently, no regular expression replacement patterns for PageCgroup*
flag-ops are defined, which causes quite a few pain while reading code.
Just get rid of it.
Also, add a comment to inform people to
12 matches
Mail list logo
