Re: [PATCH] scsi: fix the build warning

2013-09-20 Thread Paul Bolle
On Fri, 2013-09-20 at 23:32 +0900, Akinobu Mita wrote: > Yesterday, I sent a patch set which includes two fixes for this issue. > I wish this to be merged and I'll do my best. I hadn't yet stumbled onto these patches. Thanks! Paul Bolle -- To unsubscribe from this list: send the line "unsubscri

Re: [PATCH] scsi: fix the build warning

2013-09-20 Thread Akinobu Mita
2013/9/20 Paul Bolle : > On Thu, 2013-08-22 at 23:49 +0900, Akinobu Mita wrote: >> 2013/8/22 James Bottomley : >> > On Thu, 2013-08-22 at 21:42 +0900, Akinobu Mita wrote: >> >> Unfortunately, this warning isn't fixed in linux-next, either. >> >> Paul Bolle also sent a patch that fixes the same warn

Re: [PATCH] scsi: fix the build warning

2013-09-20 Thread Paul Bolle
On Thu, 2013-08-22 at 23:49 +0900, Akinobu Mita wrote: > 2013/8/22 James Bottomley : > > On Thu, 2013-08-22 at 21:42 +0900, Akinobu Mita wrote: > >> Unfortunately, this warning isn't fixed in linux-next, either. > >> Paul Bolle also sent a patch that fixes the same warning in a little > >> bit diff

Re: [PATCH] scsi: fix the build warning

2013-08-22 Thread Akinobu Mita
2013/8/22 James Bottomley : > On Thu, 2013-08-22 at 21:42 +0900, Akinobu Mita wrote: >> 2013/8/22 Martin K. Petersen : >> >> "Joe" == Joe Perches writes: >> > >> > Joe> I don't get this build warning in the first place and I think the >> > Joe> scsi_debug file is quite old and probably doesn't

Re: [PATCH] scsi: fix the build warning

2013-08-22 Thread James Bottomley
On Thu, 2013-08-22 at 21:42 +0900, Akinobu Mita wrote: > 2013/8/22 Martin K. Petersen : > >> "Joe" == Joe Perches writes: > > > > Joe> I don't get this build warning in the first place and I think the > > Joe> scsi_debug file is quite old and probably doesn't need to be > > Joe> changed at all

Re: [PATCH] scsi: fix the build warning

2013-08-22 Thread Akinobu Mita
2013/8/22 Martin K. Petersen : >> "Joe" == Joe Perches writes: > > Joe> I don't get this build warning in the first place and I think the > Joe> scsi_debug file is quite old and probably doesn't need to be > Joe> changed at all. > > guard isn't a boolean, it selects the checksum algorithm used

Re: [PATCH] scsi: fix the build warning

2013-08-21 Thread Joe Perches
On Thu, 2013-08-22 at 09:59 +0800, Zhi Yong Wu wrote: > On Thu, Aug 22, 2013 at 9:55 AM, Joe Perches wrote: > > On Wed, 2013-08-21 at 21:25 -0400, Martin K. Petersen wrote: > >> > "Joe" == Joe Perches writes: > >> > >> Joe> I don't get this build warning in the first place and I think the > >

Re: [PATCH] scsi: fix the build warning

2013-08-21 Thread Zhi Yong Wu
On Thu, Aug 22, 2013 at 9:55 AM, Joe Perches wrote: > On Wed, 2013-08-21 at 21:25 -0400, Martin K. Petersen wrote: >> > "Joe" == Joe Perches writes: >> >> Joe> I don't get this build warning in the first place and I think the >> Joe> scsi_debug file is quite old and probably doesn't need to b

Re: [PATCH] scsi: fix the build warning

2013-08-21 Thread Joe Perches
On Wed, 2013-08-21 at 21:25 -0400, Martin K. Petersen wrote: > > "Joe" == Joe Perches writes: > > Joe> I don't get this build warning in the first place and I think the > Joe> scsi_debug file is quite old and probably doesn't need to be > Joe> changed at all. > > guard isn't a boolean, it se

Re: [PATCH] scsi: fix the build warning

2013-08-21 Thread Martin K. Petersen
> "Joe" == Joe Perches writes: Joe> I don't get this build warning in the first place and I think the Joe> scsi_debug file is quite old and probably doesn't need to be Joe> changed at all. guard isn't a boolean, it selects the checksum algorithm used. Also, I believe Akinobu's recent reorga

Re: [PATCH] scsi: fix the build warning

2013-08-21 Thread Joe Perches
On Thu, 2013-08-22 at 09:05 +0800, Zhi Yong Wu wrote: > HI, Hi. > If you'd like, you should draft one patch for this warning. Not for me. I don't get this build warning in the first place and I think the scsi_debug file is quite old and probably doesn't need to be changed at all. I think scsi_

Re: [PATCH] scsi: fix the build warning

2013-08-21 Thread Zhi Yong Wu
HI, If you'd like, you should draft one patch for this warning. On Thu, Aug 22, 2013 at 9:02 AM, Joe Perches wrote: > On Thu, 2013-08-22 at 08:44 +0800, zwu.ker...@gmail.com wrote: >> From: Zhi Yong Wu >> >> Initialize csum variable to fix the build warning. > > Maybe it'd be better to change

Re: [PATCH] scsi: fix the build warning

2013-08-21 Thread Joe Perches
On Thu, 2013-08-22 at 08:44 +0800, zwu.ker...@gmail.com wrote: > From: Zhi Yong Wu > > Initialize csum variable to fix the build warning. Maybe it'd be better to change the variable scsi_debug_guard type to bool? Something like: --- drivers/scsi/scsi_debug.c | 22 +++--- 1 fi

[PATCH] scsi: fix the build warning

2013-08-21 Thread zwu . kernel
From: Zhi Yong Wu Initialize csum variable to fix the build warning. drivers/scsi/scsi_debug.c: In function ‘dif_verify’: drivers/scsi/scsi_debug.c:1755:3: warning: ‘csum’ may be used uninitialized in this function [-Wmaybe-uninitialized] LD drivers/built-in.o CHK include/generat