Re: [PATCH] scsi: iscsi: Switch to using the new API kobj_to_dev()

2021-03-07 Thread James Bottomley
On Mon, 2021-03-08 at 11:34 +0800, Jiapeng Chong wrote: > Fix the following coccicheck warnings: > > ./drivers/scsi/scsi_transport_iscsi.c:930:60-61: WARNING opportunity > for kobj_to_dev(). I have to ask, what is the point of this? container_of is usually pretty safe ... as in it will detect

[PATCH] scsi: iscsi: Switch to using the new API kobj_to_dev()

2021-03-07 Thread Jiapeng Chong
Fix the following coccicheck warnings: ./drivers/scsi/scsi_transport_iscsi.c:930:60-61: WARNING opportunity for kobj_to_dev(). Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/scsi/scsi_transport_iscsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] scsi: iscsi: Switch to using the new API kobj_to_dev()

2021-03-02 Thread Jiapeng Chong
Fix the following coccicheck warnings: ./drivers/scsi/scsi_transport_iscsi.c:4453:61-62: WARNING opportunity for kobj_to_dev(). ./drivers/scsi/scsi_transport_iscsi.c:4309:61-62: WARNING opportunity for kobj_to_dev(). ./drivers/scsi/scsi_transport_iscsi.c:4040:61-62: WARNING opportunity for

Re: [PATCH] scsi: iscsi: Switch to using the new API kobj_to_dev()

2021-02-22 Thread John Garry
On 22/02/2021 07:26, Yang Li wrote: fixed the following coccicheck: ./drivers/scsi/scsi_transport_iscsi.c:436:60-61: WARNING opportunity for kobj_to_dev() ./drivers/scsi/scsi_transport_iscsi.c:1128:60-61: WARNING opportunity for kobj_to_dev() ./drivers/scsi/scsi_transport_iscsi.c:4043:61-62:

[PATCH] scsi: iscsi: Switch to using the new API kobj_to_dev()

2021-02-21 Thread Yang Li
fixed the following coccicheck: ./drivers/scsi/scsi_transport_iscsi.c:436:60-61: WARNING opportunity for kobj_to_dev() ./drivers/scsi/scsi_transport_iscsi.c:1128:60-61: WARNING opportunity for kobj_to_dev() ./drivers/scsi/scsi_transport_iscsi.c:4043:61-62: WARNING opportunity for kobj_to_dev()