Re: [PATCH] scsi: mvumi: fix 32 bit shift of a 32 bit unsigned int

2019-02-18 Thread Dan Carpenter
On Mon, Feb 18, 2019 at 07:32:05AM -0800, James Bottomley wrote: > On Mon, 2019-02-18 at 12:37 +0300, Dan Carpenter wrote: > > On Sat, Feb 16, 2019 at 05:27:16PM +0100, Walter Harms wrote: > > > Am 16.02.2019 15:44, schrieb Colin King: > > > > From: Colin Ian King > > > > > > > > Currently m_sg->

Re: [PATCH] scsi: mvumi: fix 32 bit shift of a 32 bit unsigned int

2019-02-18 Thread James Bottomley
On Mon, 2019-02-18 at 12:37 +0300, Dan Carpenter wrote: > On Sat, Feb 16, 2019 at 05:27:16PM +0100, Walter Harms wrote: > > Am 16.02.2019 15:44, schrieb Colin King: > > > From: Colin Ian King > > > > > > Currently m_sg->baseaddr_h (a 32 bit unsigned int) is being > > > shifted by a > > > total of

Re: [PATCH] scsi: mvumi: fix 32 bit shift of a 32 bit unsigned int

2019-02-18 Thread Dan Carpenter
On Sat, Feb 16, 2019 at 05:27:16PM +0100, Walter Harms wrote: > Am 16.02.2019 15:44, schrieb Colin King: > > From: Colin Ian King > > > > Currently m_sg->baseaddr_h (a 32 bit unsigned int) is being shifted by a > > total of 32 bits; this always produces a 0 result. Fix this by casting > > it to

Re: [PATCH] scsi: mvumi: fix 32 bit shift of a 32 bit unsigned int

2019-02-16 Thread Walter Harms
Am 16.02.2019 15:44, schrieb Colin King: > From: Colin Ian King > > Currently m_sg->baseaddr_h (a 32 bit unsigned int) is being shifted by a > total of 32 bits; this always produces a 0 result. Fix this by casting > it to a dma_addr_t (a 64 bit unsigned int) before performing the shift. > > Det

[PATCH] scsi: mvumi: fix 32 bit shift of a 32 bit unsigned int

2019-02-16 Thread Colin King
From: Colin Ian King Currently m_sg->baseaddr_h (a 32 bit unsigned int) is being shifted by a total of 32 bits; this always produces a 0 result. Fix this by casting it to a dma_addr_t (a 64 bit unsigned int) before performing the shift. Detected by CoverityScan, CID#147270 ("Operands don't affe