Re: [PATCH] scsi: sg: fix SG_DXFER_FROM_DEV transfers

2017-07-07 Thread Johannes Thumshirn
On Thu, Jul 06, 2017 at 02:47:22PM -0400, Douglas Gilbert wrote: > Can you check your patch with one of the utilities from sg3_utils > such as sg_inq which will use SG_DXFER_FROM_DEV with the newer > interface? Correct, this patch broke sg_inq. I'll send a corrected v2. > BTW I'm not sure why dxf

Re: [PATCH] scsi: sg: fix SG_DXFER_FROM_DEV transfers

2017-07-06 Thread Douglas Gilbert
On 2017-07-05 09:49 AM, Johannes Thumshirn wrote: SG_DXFER_FROM_DEV transfers do not have a dxferp as we set it to NULL, but must have a length bigger than 0. This fixes a regression introduced by commit 28676d869bbb ("scsi: sg: check for valid direction before starting the request") It is not

Re: [PATCH] scsi: sg: fix SG_DXFER_FROM_DEV transfers

2017-07-06 Thread Hannes Reinecke
On 07/05/2017 03:49 PM, Johannes Thumshirn wrote: > SG_DXFER_FROM_DEV transfers do not have a dxferp as we set it to NULL, > but must have a length bigger than 0. This fixes a regression introduced > by commit 28676d869bbb ("scsi: sg: check for valid direction before > starting the request") > > S

[PATCH] scsi: sg: fix SG_DXFER_FROM_DEV transfers

2017-07-05 Thread Johannes Thumshirn
SG_DXFER_FROM_DEV transfers do not have a dxferp as we set it to NULL, but must have a length bigger than 0. This fixes a regression introduced by commit 28676d869bbb ("scsi: sg: check for valid direction before starting the request") Signed-off-by: Johannes Thumshirn Fixes: 28676d869bbb ("scsi: