Re: [PATCH] scsi: st: convert convert get_user_pages() --> pin_user_pages()

2020-05-26 Thread John Hubbard
On 2020-05-22 01:32, "Kai Mäkisara (Kolumbus)" wrote: On 21. May 2020, at 22.47, Bart Van Assche wrote: On 2020-05-18 21:55, John Hubbard wrote: This code was using get_user_pages*(), in a "Case 2" scenario (DMA/RDMA), using the categorization from [1]. That means that it's time to convert

Re: [PATCH] scsi: st: convert convert get_user_pages() --> pin_user_pages()

2020-05-22 Thread Kai Mäkisara (Kolumbus)
> On 21. May 2020, at 22.47, Bart Van Assche wrote: > > On 2020-05-18 21:55, John Hubbard wrote: >> This code was using get_user_pages*(), in a "Case 2" scenario >> (DMA/RDMA), using the categorization from [1]. That means that it's >> time to convert the get_user_pages*() + put_page() calls

Re: [PATCH] scsi: st: convert convert get_user_pages() --> pin_user_pages()

2020-05-21 Thread Bart Van Assche
On 2020-05-21 12:57, John Hubbard wrote: > Also, I doubt if it's worth it, but do you want a patch to change > SetPageDirty() > to set_page_dirty_lock(), meanwhile? It seems like if that's never come > up, then > it's mostly a theoretical bug. Hi John, Since I do not use the st driver myself I

Re: [PATCH] scsi: st: convert convert get_user_pages() --> pin_user_pages()

2020-05-21 Thread John Hubbard
On 2020-05-21 12:47, Bart Van Assche wrote: On 2020-05-18 21:55, John Hubbard wrote: This code was using get_user_pages*(), in a "Case 2" scenario (DMA/RDMA), using the categorization from [1]. That means that it's time to convert the get_user_pages*() + put_page() calls to pin_user_pages*() +

Re: [PATCH] scsi: st: convert convert get_user_pages() --> pin_user_pages()

2020-05-21 Thread Bart Van Assche
On 2020-05-18 21:55, John Hubbard wrote: > This code was using get_user_pages*(), in a "Case 2" scenario > (DMA/RDMA), using the categorization from [1]. That means that it's > time to convert the get_user_pages*() + put_page() calls to > pin_user_pages*() + unpin_user_pages() calls. > > There is

Re: [PATCH] scsi: st: convert convert get_user_pages() --> pin_user_pages()

2020-05-19 Thread Martin K. Petersen
John, > Looks like I accidentally doubled a word on the subject line: "convert > convert". > > I'd appreciate it a maintainer could remove one of those for me, while > applying the patch, assuming that we don't need a v2 for other > reasons. I can fix that up. But I'll give Kai a chance to

Re: [PATCH] scsi: st: convert convert get_user_pages() --> pin_user_pages()

2020-05-19 Thread John Hubbard
On 2020-05-18 21:55, John Hubbard wrote: This code was using get_user_pages*(), in a "Case 2" scenario (DMA/RDMA), using the categorization from [1]. That means that it's time to convert the get_user_pages*() + put_page() calls to pin_user_pages*() + unpin_user_pages() calls. Looks like I

[PATCH] scsi: st: convert convert get_user_pages() --> pin_user_pages()

2020-05-18 Thread John Hubbard
This code was using get_user_pages*(), in a "Case 2" scenario (DMA/RDMA), using the categorization from [1]. That means that it's time to convert the get_user_pages*() + put_page() calls to pin_user_pages*() + unpin_user_pages() calls. There is some helpful background in [2]: basically, this is a