Re: [PATCH] scsi: ufs: Tidy up WB configuration code

2021-03-17 Thread Yue Hu
On Wed, 17 Mar 2021 14:02:23 + Avri Altman wrote: > > > > From: Yue Hu > > > > There are similar code implemetentions for WB configurations in > > ufshcd_wb_{ctrl, toggle_flush_during_h8, toggle_flush}. We can > > extract the part to create a new helper with a flag parameter to > > reduce

RE: [PATCH] scsi: ufs: Tidy up WB configuration code

2021-03-17 Thread Avri Altman
> > From: Yue Hu > > There are similar code implemetentions for WB configurations in > ufshcd_wb_{ctrl, toggle_flush_during_h8, toggle_flush}. We can > extract the part to create a new helper with a flag parameter to > reduce code duplication. > > Meanwhile, change ufshcd_wb_ctrl() ->

[PATCH] scsi: ufs: Tidy up WB configuration code

2021-03-17 Thread Yue Hu
From: Yue Hu There are similar code implemetentions for WB configurations in ufshcd_wb_{ctrl, toggle_flush_during_h8, toggle_flush}. We can extract the part to create a new helper with a flag parameter to reduce code duplication. Meanwhile, change ufshcd_wb_ctrl() -> ufshcd_wb_toggle() for