Re: [PATCH] security: mark expected switch fall-throughs

2019-02-01 Thread James Morris
On Thu, 31 Jan 2019, Gustavo A. R. Silva wrote: > > > On 1/31/19 2:20 PM, Mimi Zohar wrote: > > >>> > >>> This patch touches multiple LSMs and IMA.  As James has already picked > >>> up similar patches, which are in his next-general branch, perhaps he > >>> could also pick up an updated

Re: [PATCH] security: mark expected switch fall-throughs

2019-01-31 Thread Gustavo A. R. Silva
On 1/31/19 2:20 PM, Mimi Zohar wrote: >>> >>> This patch touches multiple LSMs and IMA.  As James has already picked >>> up similar patches, which are in his next-general branch, perhaps he >>> could also pick up an updated version of this one. >>> >> >> Yeah. I can either integrate your

Re: [PATCH] security: mark expected switch fall-throughs

2019-01-31 Thread Mimi Zohar
On Thu, 2019-01-31 at 14:12 -0600, Gustavo A. R. Silva wrote: > Mimi, > > On 1/31/19 1:58 PM, Mimi Zohar wrote: > > [Cc'ing James Morris] > > > > On Thu, 2019-01-24 at 21:47 -0600, Gustavo A. R. Silva wrote: > > > > Signed-off-by: Gustavo A. R. Silva > > Acked-by: Casey Schaufler

Re: [PATCH] security: mark expected switch fall-throughs

2019-01-31 Thread Gustavo A. R. Silva
Mimi, On 1/31/19 1:58 PM, Mimi Zohar wrote: > [Cc'ing James Morris] > > On Thu, 2019-01-24 at 21:47 -0600, Gustavo A. R. Silva wrote: > > Signed-off-by: Gustavo A. R. Silva Acked-by: Casey Schaufler >> >> BTW, thanks, Casey. I'll take this in my tree. > > This patch

Re: [PATCH] security: mark expected switch fall-throughs

2019-01-31 Thread Mimi Zohar
[Cc'ing James Morris] On Thu, 2019-01-24 at 21:47 -0600, Gustavo A. R. Silva wrote: > >>> Signed-off-by: Gustavo A. R. Silva > >> > >> Acked-by: Casey Schaufler > >> > > BTW, thanks, Casey. I'll take this in my tree. This patch touches multiple LSMs and IMA.  As James has already picked up

Re: [PATCH] security: mark expected switch fall-throughs

2019-01-25 Thread Mimi Zohar
On Thu, 2019-01-24 at 20:56 -0600, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. > > This patch fixes the following warnings: > > security/integrity/ima/ima_appraise.c:116:26: warning: this statement

Re: [PATCH] security: mark expected switch fall-throughs

2019-01-24 Thread John Johansen
On 1/24/19 6:56 PM, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. > > This patch fixes the following warnings: > > security/integrity/ima/ima_appraise.c:116:26: warning: this statement may > fall

Re: [PATCH] security: mark expected switch fall-throughs

2019-01-24 Thread Gustavo A. R. Silva
On 1/24/19 9:29 PM, Gustavo A. R. Silva wrote: > > > On 1/24/19 9:13 PM, Casey Schaufler wrote: >> On 1/24/2019 6:56 PM, Gustavo A. R. Silva wrote: >>> In preparation to enabling -Wimplicit-fallthrough, mark switch >>> cases where we are expecting to fall through. >>> >>> This patch fixes the

Re: [PATCH] security: mark expected switch fall-throughs

2019-01-24 Thread Gustavo A. R. Silva
On 1/24/19 9:13 PM, Casey Schaufler wrote: > On 1/24/2019 6:56 PM, Gustavo A. R. Silva wrote: >> In preparation to enabling -Wimplicit-fallthrough, mark switch >> cases where we are expecting to fall through. >> >> This patch fixes the following warnings: >> >>

Re: [PATCH] security: mark expected switch fall-throughs

2019-01-24 Thread Casey Schaufler
On 1/24/2019 6:56 PM, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. > > This patch fixes the following warnings: > > security/integrity/ima/ima_appraise.c:116:26: warning: this statement may > fall

[PATCH] security: mark expected switch fall-throughs

2019-01-24 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. This patch fixes the following warnings: security/integrity/ima/ima_appraise.c:116:26: warning: this statement may fall through [-Wimplicit-fallthrough=]