Re: [PATCH] selftests/bpf: fix compile errors with older glibc

2019-04-18 Thread Yonghong Song
On 4/18/19 11:00 AM, Wang YanQing wrote: > On Thu, Apr 18, 2019 at 05:09:53AM +, Yonghong Song wrote: >> >> >> On 4/17/19 10:48 AM, Wang YanQing wrote: >>> The older glibc (for example, 2.23) doesn't handle __UAPI_DEF_* >>> in libc-compat.h properly, and it bring below compile errors: >> >> I

Re: [PATCH] selftests/bpf: fix compile errors with older glibc

2019-04-18 Thread Wang YanQing
On Thu, Apr 18, 2019 at 05:09:53AM +, Yonghong Song wrote: > > > On 4/17/19 10:48 AM, Wang YanQing wrote: > > The older glibc (for example, 2.23) doesn't handle __UAPI_DEF_* > > in libc-compat.h properly, and it bring below compile errors: > > I have an even old glibc 2.17 and it still works

Re: [PATCH] selftests/bpf: fix compile errors with older glibc

2019-04-18 Thread Wang YanQing
On Thu, Apr 18, 2019 at 05:09:53AM +, Yonghong Song wrote: > > > On 4/17/19 10:48 AM, Wang YanQing wrote: > > The older glibc (for example, 2.23) doesn't handle __UAPI_DEF_* > > in libc-compat.h properly, and it bring below compile errors: > > I have an even old glibc 2.17 and it still works

Re: [PATCH] selftests/bpf: fix compile errors with older glibc

2019-04-17 Thread Yonghong Song
On 4/17/19 10:48 AM, Wang YanQing wrote: > The older glibc (for example, 2.23) doesn't handle __UAPI_DEF_* > in libc-compat.h properly, and it bring below compile errors: I have an even old glibc 2.17 and it still works. Not sure why it failed here. Could you explain more? But I applied the cha

[PATCH] selftests/bpf: fix compile errors with older glibc

2019-04-17 Thread Wang YanQing
The older glibc (for example, 2.23) doesn't handle __UAPI_DEF_* in libc-compat.h properly, and it bring below compile errors: " In file included from test_tcpnotify_kern.c:12: /usr/include/netinet/in.h:101:5: error: expected identifier IPPROTO_HOPOPTS = 0, /* IPv6 Hop-by-Hop options. */