Re: [PATCH] selftests/ftrace: skip ftrace test if FTRACE was not enabled

2019-07-04 Thread Po-Hsu Lin
Hello, Thanks all for your feedback! On Wed, Jul 3, 2019 at 8:11 AM Masami Hiramatsu wrote: > > Hi Po-Hsu Lin, > > On Tue, 2 Jul 2019 13:22:26 -0600 > shuah wrote: > > > Hi Po-Hsu Lin, > > > > On 7/2/19 12:23 AM, Po-Hsu Lin wrote: > > > The ftrace test will need to have CONFIG_FTRACE enabled to

Re: [PATCH] selftests/ftrace: skip ftrace test if FTRACE was not enabled

2019-07-03 Thread Masami Hiramatsu
On Tue, 2 Jul 2019 23:18:08 -0400 Steven Rostedt wrote: > On Wed, 3 Jul 2019 12:09:53 +0900 > Masami Hiramatsu wrote: > > > > Would something like that work? > > > > For older kernel, I think we'd better try to mount debugfs first. > > Sure, that's pretty trivial to do. Or what I was

Re: [PATCH] selftests/ftrace: skip ftrace test if FTRACE was not enabled

2019-07-02 Thread Steven Rostedt
On Wed, 3 Jul 2019 12:09:53 +0900 Masami Hiramatsu wrote: > > Would something like that work? > > For older kernel, I think we'd better try to mount debugfs first. Sure, that's pretty trivial to do. Or what I was thinking, try it if it fails: if [ -z "$TRACING_DIR" ]; then

Re: [PATCH] selftests/ftrace: skip ftrace test if FTRACE was not enabled

2019-07-02 Thread Masami Hiramatsu
On Tue, 2 Jul 2019 21:07:30 -0400 Steven Rostedt wrote: > On Wed, 3 Jul 2019 09:11:47 +0900 > Masami Hiramatsu wrote: > > > Hi Po-Hsu Lin, > > > > On Tue, 2 Jul 2019 13:22:26 -0600 > > shuah wrote: > > > > > Hi Po-Hsu Lin, > > > > > > On 7/2/19 12:23 AM, Po-Hsu Lin wrote: > > > > The

Re: [PATCH] selftests/ftrace: skip ftrace test if FTRACE was not enabled

2019-07-02 Thread Steven Rostedt
On Wed, 3 Jul 2019 09:11:47 +0900 Masami Hiramatsu wrote: > Hi Po-Hsu Lin, > > On Tue, 2 Jul 2019 13:22:26 -0600 > shuah wrote: > > > Hi Po-Hsu Lin, > > > > On 7/2/19 12:23 AM, Po-Hsu Lin wrote: > > > The ftrace test will need to have CONFIG_FTRACE enabled to make the > > > ftrace

Re: [PATCH] selftests/ftrace: skip ftrace test if FTRACE was not enabled

2019-07-02 Thread Masami Hiramatsu
Hi Po-Hsu Lin, On Tue, 2 Jul 2019 13:22:26 -0600 shuah wrote: > Hi Po-Hsu Lin, > > On 7/2/19 12:23 AM, Po-Hsu Lin wrote: > > The ftrace test will need to have CONFIG_FTRACE enabled to make the > > ftrace directory available. > > > > Add an additional check to skip this test if the

Re: [PATCH] selftests/ftrace: skip ftrace test if FTRACE was not enabled

2019-07-02 Thread shuah
Hi Po-Hsu Lin, On 7/2/19 12:23 AM, Po-Hsu Lin wrote: The ftrace test will need to have CONFIG_FTRACE enabled to make the ftrace directory available. Add an additional check to skip this test if the CONFIG_FTRACE was not enabled. This will be helpful to avoid a false-positive test result when

[PATCH] selftests/ftrace: skip ftrace test if FTRACE was not enabled

2019-07-02 Thread Po-Hsu Lin
The ftrace test will need to have CONFIG_FTRACE enabled to make the ftrace directory available. Add an additional check to skip this test if the CONFIG_FTRACE was not enabled. This will be helpful to avoid a false-positive test result when testing it directly with the following commad against a