Re: [PATCH] selftests/ftrace: treat module requirement unmet situation as unsupported

2020-05-04 Thread Po-Hsu Lin
On Fri, May 1, 2020 at 9:59 AM Masami Hiramatsu wrote: > > Hi, > > On Wed, 29 Apr 2020 17:50:44 +0800 > Po-Hsu Lin wrote: > > > When the required module for the test does not exist, use > > exit_unsupported instead of exit_unresolved to indicate this test is > > not supported. > > Hmm, this

Re: [PATCH] selftests/ftrace: treat module requirement unmet situation as unsupported

2020-04-30 Thread Masami Hiramatsu
Hi, On Wed, 29 Apr 2020 17:50:44 +0800 Po-Hsu Lin wrote: > When the required module for the test does not exist, use > exit_unsupported instead of exit_unresolved to indicate this test is > not supported. Hmm, this doesn't mean "the function is not supported" but "we can not resolve this

Re: [PATCH] selftests/ftrace: treat module requirement unmet situation as unsupported

2020-04-29 Thread Steven Rostedt
On Thu, 30 Apr 2020 09:46:36 +0800 Po-Hsu Lin wrote: > > I'm fine with these changes if Masami is. But it is Masami's call as his > > infrastructure is more sensitive to the return calls than mine. I just run > > the test and see what passes. I don't actually look at the return codes. >

Re: [PATCH] selftests/ftrace: treat module requirement unmet situation as unsupported

2020-04-29 Thread Po-Hsu Lin
On Thu, Apr 30, 2020 at 12:29 AM Steven Rostedt wrote: > > On Wed, 29 Apr 2020 17:50:44 +0800 > Po-Hsu Lin wrote: > > > When the required module for the test does not exist, use > > exit_unsupported instead of exit_unresolved to indicate this test is > > not supported. > > > > By doing this we

Re: [PATCH] selftests/ftrace: treat module requirement unmet situation as unsupported

2020-04-29 Thread Steven Rostedt
On Wed, 29 Apr 2020 17:50:44 +0800 Po-Hsu Lin wrote: > When the required module for the test does not exist, use > exit_unsupported instead of exit_unresolved to indicate this test is > not supported. > > By doing this we can make test behaviour in sync with the > irqsoff_tracer.tc test in

Re: [PATCH] selftests/ftrace: treat module requirement unmet situation as unsupported

2020-04-29 Thread Xiao Yang
Hi Lin, It looks fine to me. Reviewed-by: Xiao Yang Thanks, Xiao Yang On 2020/4/29 17:50, Po-Hsu Lin wrote: > When the required module for the test does not exist, use > exit_unsupported instead of exit_unresolved to indicate this test is > not supported. > > By doing this we can make test

[PATCH] selftests/ftrace: treat module requirement unmet situation as unsupported

2020-04-29 Thread Po-Hsu Lin
When the required module for the test does not exist, use exit_unsupported instead of exit_unresolved to indicate this test is not supported. By doing this we can make test behaviour in sync with the irqsoff_tracer.tc test in preemptirq, which is also treating module existence in this way.