Re: [PATCH] selinux: fix another double free

2020-06-11 Thread Ondrej Mosnacek
Hi Tom, On Thu, Jun 11, 2020 at 5:58 PM wrote: > From: Tom Rix > > Clang static analysis reports this double free error > > security/selinux/ss/conditional.c:139:2: warning: Attempt to free released > memory [unix.Malloc] > kfree(node->expr.nodes); > ^~~ > >

Re: [PATCH] selinux: fix another double free

2020-06-11 Thread Stephen Smalley
On Thu, Jun 11, 2020 at 11:58 AM wrote: > > From: Tom Rix > > Clang static analysis reports this double free error > > security/selinux/ss/conditional.c:139:2: warning: Attempt to free released > memory [unix.Malloc] > kfree(node->expr.nodes); > ^~~ > > When

[PATCH] selinux: fix another double free

2020-06-11 Thread trix
From: Tom Rix Clang static analysis reports this double free error security/selinux/ss/conditional.c:139:2: warning: Attempt to free released memory [unix.Malloc] kfree(node->expr.nodes); ^~~ When cond_read_node fails, it calls cond_node_destroy which frees