Re: [PATCH] selinux: fix undefined return of cond_evaluate_expr

2020-06-17 Thread Paul Moore
On Wed, Jun 17, 2020 at 4:51 PM Paul Moore wrote: > On Wed, Jun 17, 2020 at 9:58 AM Stephen Smalley > wrote: > > On Wed, Jun 17, 2020 at 8:40 AM wrote: > > > > > > From: Tom Rix > > > > > > clang static analysis reports an undefined return > > > > > > security/selinux/ss/conditional.c:79:2: war

Re: [PATCH] selinux: fix undefined return of cond_evaluate_expr

2020-06-17 Thread Paul Moore
On Wed, Jun 17, 2020 at 9:58 AM Stephen Smalley wrote: > On Wed, Jun 17, 2020 at 8:40 AM wrote: > > > > From: Tom Rix > > > > clang static analysis reports an undefined return > > > > security/selinux/ss/conditional.c:79:2: warning: Undefined or garbage value > > returned to caller [core.uninit

Re: [PATCH] selinux: fix undefined return of cond_evaluate_expr

2020-06-17 Thread Stephen Smalley
On Wed, Jun 17, 2020 at 8:40 AM wrote: > > From: Tom Rix > > clang static analysis reports an undefined return > > security/selinux/ss/conditional.c:79:2: warning: Undefined or garbage value > returned to caller [core.uninitialized.UndefReturn] > return s[0]; > ^~~ > > st

[PATCH] selinux: fix undefined return of cond_evaluate_expr

2020-06-17 Thread trix
From: Tom Rix clang static analysis reports an undefined return security/selinux/ss/conditional.c:79:2: warning: Undefined or garbage value returned to caller [core.uninitialized.UndefReturn] return s[0]; ^~~ static int cond_evaluate_expr( ... { u32 i; i