Re: [PATCH] serial/sifive: select SERIAL_EARLYCON

2019-10-04 Thread Atish Patra
On Mon, 2019-09-16 at 14:38 -0700, Palmer Dabbelt wrote: > On Mon, 16 Sep 2019 12:40:10 PDT (-0700), sch...@suse.de wrote: > > On Sep 16 2019, Palmer Dabbelt wrote: > > > > > On Sun, 15 Sep 2019 23:42:53 PDT (-0700), Christoph Hellwig > > > wrote: > > > > On Fri, Sep 13, 2019 at 01:40:27PM

Re: [PATCH] serial/sifive: select SERIAL_EARLYCON

2019-09-17 Thread Andreas Schwab
On Sep 16 2019, Palmer Dabbelt wrote: > but we don't set it for the HiFive Unleashed. I'd call that a bug, > something like this > > diff --git a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts > b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts > index 93d68cbd64fe..6d0ec76d93fe

Re: [PATCH] serial/sifive: select SERIAL_EARLYCON

2019-09-16 Thread Palmer Dabbelt
On Mon, 16 Sep 2019 12:40:10 PDT (-0700), sch...@suse.de wrote: On Sep 16 2019, Palmer Dabbelt wrote: On Sun, 15 Sep 2019 23:42:53 PDT (-0700), Christoph Hellwig wrote: On Fri, Sep 13, 2019 at 01:40:27PM -0700, Palmer Dabbelt wrote: OpenEmbedded passes "earlycon=sbi", which I can find in

Re: [PATCH] serial/sifive: select SERIAL_EARLYCON

2019-09-16 Thread Andreas Schwab
On Sep 16 2019, Palmer Dabbelt wrote: > On Sun, 15 Sep 2019 23:42:53 PDT (-0700), Christoph Hellwig wrote: >> On Fri, Sep 13, 2019 at 01:40:27PM -0700, Palmer Dabbelt wrote: >>> OpenEmbedded passes "earlycon=sbi", which I can find in the doumentation. >>> I can't find anything about just

Re: [PATCH] serial/sifive: select SERIAL_EARLYCON

2019-09-16 Thread Palmer Dabbelt
On Sun, 15 Sep 2019 23:42:53 PDT (-0700), Christoph Hellwig wrote: On Fri, Sep 13, 2019 at 01:40:27PM -0700, Palmer Dabbelt wrote: OpenEmbedded passes "earlycon=sbi", which I can find in the doumentation. I can't find anything about just "earlycon". I've sent a patch adding sbi to the list of

Re: [PATCH] serial/sifive: select SERIAL_EARLYCON

2019-09-16 Thread Christoph Hellwig
On Mon, Sep 16, 2019 at 05:18:57AM -0700, Paul Walmsley wrote: > I support Christoph's plan to add generic implicit earlycon support. I'm not planning to add it, it exist already. You just need a DT that sets the stdout node up properly, and a earlycon driver using OF_EARLYCON_DECLARE like the

Re: [PATCH] serial/sifive: select SERIAL_EARLYCON

2019-09-16 Thread Paul Walmsley
On Mon, 16 Sep 2019, Andreas Schwab wrote: > On Sep 16 2019, Paul Walmsley wrote: > > > On Tue, 10 Sep 2019, Andreas Schwab wrote: > > > >> On Sep 10 2019, Christoph Hellwig wrote: > >> > >> > On Tue, Sep 10, 2019 at 08:57:37AM +0200, Andreas Schwab wrote: > >> >> On Sep 10 2019, Christoph

Re: [PATCH] serial/sifive: select SERIAL_EARLYCON

2019-09-16 Thread Christoph Hellwig
On Mon, Sep 16, 2019 at 02:00:39PM +0200, Andreas Schwab wrote: > > Try: > > > > earlycon=sifive,0x1001 > > That's not what Christoph wants. Well, what I want is auto selection if the device tree uses the stdout-path. My Kendryte DT uses that and it works like a charm. If it doesn't

Re: [PATCH] serial/sifive: select SERIAL_EARLYCON

2019-09-16 Thread Andreas Schwab
On Sep 16 2019, Paul Walmsley wrote: > On Tue, 10 Sep 2019, Andreas Schwab wrote: > >> On Sep 10 2019, Christoph Hellwig wrote: >> >> > On Tue, Sep 10, 2019 at 08:57:37AM +0200, Andreas Schwab wrote: >> >> On Sep 10 2019, Christoph Hellwig wrote: >> >> >> >> > The sifive serial driver

Re: [PATCH] serial/sifive: select SERIAL_EARLYCON

2019-09-16 Thread Paul Walmsley
On Tue, 10 Sep 2019, Andreas Schwab wrote: > On Sep 10 2019, Christoph Hellwig wrote: > > > On Tue, Sep 10, 2019 at 08:57:37AM +0200, Andreas Schwab wrote: > >> On Sep 10 2019, Christoph Hellwig wrote: > >> > >> > The sifive serial driver implements earlycon support, > >> > >> It should

Re: [PATCH] serial/sifive: select SERIAL_EARLYCON

2019-09-16 Thread Paul Walmsley
On Tue, 10 Sep 2019, Christoph Hellwig wrote: > The sifive serial driver implements earlycon support, but unless > another driver is built in that supports earlycon support it won't > be usable. Explicitly select SERIAL_EARLYCON instead. > > Signed-off-by: Christoph Hellwig Reviewed-by: Paul

Re: [PATCH] serial/sifive: select SERIAL_EARLYCON

2019-09-16 Thread Christoph Hellwig
On Fri, Sep 13, 2019 at 01:40:27PM -0700, Palmer Dabbelt wrote: > OpenEmbedded passes "earlycon=sbi", which I can find in the doumentation. > I can't find anything about just "earlycon". I've sent a patch adding sbi > to the list of earlycon arguments. earlycon without arguments is

Re: [PATCH] serial/sifive: select SERIAL_EARLYCON

2019-09-13 Thread Palmer Dabbelt
On Tue, 10 Sep 2019 07:36:30 PDT (-0700), Christoph Hellwig wrote: On Tue, Sep 10, 2019 at 10:18:15AM +0200, Andreas Schwab wrote: > How so? Wіth OF and a stdout path you just set earlycon on the > command line without any arguments and it will be found. Doesn't work for me. [0.00]

Re: [PATCH] serial/sifive: select SERIAL_EARLYCON

2019-09-10 Thread Andreas Schwab
On Sep 10 2019, Christoph Hellwig wrote: > On Tue, Sep 10, 2019 at 10:18:15AM +0200, Andreas Schwab wrote: >> > How so? Wіth OF and a stdout path you just set earlycon on the >> > command line without any arguments and it will be found. >> >> Doesn't work for me. >> >> [0.00]

Re: [PATCH] serial/sifive: select SERIAL_EARLYCON

2019-09-10 Thread Christoph Hellwig
On Tue, Sep 10, 2019 at 10:18:15AM +0200, Andreas Schwab wrote: > > How so? Wіth OF and a stdout path you just set earlycon on the > > command line without any arguments and it will be found. > > Doesn't work for me. > > [0.00] Malformed early option 'earlycon' That functionality is

Re: [PATCH] serial/sifive: select SERIAL_EARLYCON

2019-09-10 Thread Andreas Schwab
On Sep 10 2019, Christoph Hellwig wrote: > On Tue, Sep 10, 2019 at 08:57:37AM +0200, Andreas Schwab wrote: >> On Sep 10 2019, Christoph Hellwig wrote: >> >> > The sifive serial driver implements earlycon support, >> >> It should probably be documented in admin-guide/kernel-parameters.txt. > >

Re: [PATCH] serial/sifive: select SERIAL_EARLYCON

2019-09-10 Thread Christoph Hellwig
On Tue, Sep 10, 2019 at 08:57:37AM +0200, Andreas Schwab wrote: > On Sep 10 2019, Christoph Hellwig wrote: > > > The sifive serial driver implements earlycon support, > > It should probably be documented in admin-guide/kernel-parameters.txt. How so? Wіth OF and a stdout path you just set

Re: [PATCH] serial/sifive: select SERIAL_EARLYCON

2019-09-10 Thread Andreas Schwab
On Sep 10 2019, Christoph Hellwig wrote: > The sifive serial driver implements earlycon support, It should probably be documented in admin-guide/kernel-parameters.txt. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA

[PATCH] serial/sifive: select SERIAL_EARLYCON

2019-09-10 Thread Christoph Hellwig
The sifive serial driver implements earlycon support, but unless another driver is built in that supports earlycon support it won't be usable. Explicitly select SERIAL_EARLYCON instead. Signed-off-by: Christoph Hellwig --- drivers/tty/serial/Kconfig | 1 + 1 file changed, 1 insertion(+) diff