Re: [PATCH] serial/uart: Add tunable RX interrupt trigger I/F of FIFO buffers

2014-02-17 Thread One Thousand Gnomes
> #define TIOCSFIFORTRIG_IOW('T', 0x41, unsigned char) > > > Also, why pass a pointer to a variable, and not just the value itself? > > Ah, it's no big reason. > It will pass just the value itself in V2. We don't need ioctls here - we have a sysfs interface we can expand to do this. We also

Re: [PATCH] serial/uart: Add tunable RX interrupt trigger I/F of FIFO buffers

2014-02-17 Thread One Thousand Gnomes
#define TIOCSFIFORTRIG_IOW('T', 0x41, unsigned char) Also, why pass a pointer to a variable, and not just the value itself? Ah, it's no big reason. It will pass just the value itself in V2. We don't need ioctls here - we have a sysfs interface we can expand to do this. We also need

Re: [PATCH] serial/uart: Add tunable RX interrupt trigger I/F of FIFO buffers

2014-02-14 Thread Yoshihiro YUNOMAE
Hi Greg, Thank you for your reply. [snip] diff --git a/include/uapi/asm-generic/ioctls.h b/include/uapi/asm-generic/ioctls.h index 143dacb..d2e56a4 100644 --- a/include/uapi/asm-generic/ioctls.h +++ b/include/uapi/asm-generic/ioctls.h @@ -78,6 +78,8 @@ #define TIOCGPTLCK_IOR('T', 0x39,

Re: [PATCH] serial/uart: Add tunable RX interrupt trigger I/F of FIFO buffers

2014-02-14 Thread Yoshihiro YUNOMAE
Hi Greg, Thank you for your reply. [snip] diff --git a/include/uapi/asm-generic/ioctls.h b/include/uapi/asm-generic/ioctls.h index 143dacb..d2e56a4 100644 --- a/include/uapi/asm-generic/ioctls.h +++ b/include/uapi/asm-generic/ioctls.h @@ -78,6 +78,8 @@ #define TIOCGPTLCK_IOR('T', 0x39,

Re: [PATCH] serial/uart: Add tunable RX interrupt trigger I/F of FIFO buffers

2014-02-13 Thread Greg Kroah-Hartman
On Thu, Feb 06, 2014 at 11:16:55AM +0900, Yoshihiro YUNOMAE wrote: > Add tunable RX interrupt trigger I/F of FIFO buffers. > Serial devices are used as not only message communication devices but control > or sending communication devices. For the latter uses, normally small data > will be

Re: [PATCH] serial/uart: Add tunable RX interrupt trigger I/F of FIFO buffers

2014-02-13 Thread Greg Kroah-Hartman
On Thu, Feb 06, 2014 at 11:16:55AM +0900, Yoshihiro YUNOMAE wrote: Add tunable RX interrupt trigger I/F of FIFO buffers. Serial devices are used as not only message communication devices but control or sending communication devices. For the latter uses, normally small data will be exchanged,

[PATCH] serial/uart: Add tunable RX interrupt trigger I/F of FIFO buffers

2014-02-05 Thread Yoshihiro YUNOMAE
Add tunable RX interrupt trigger I/F of FIFO buffers. Serial devices are used as not only message communication devices but control or sending communication devices. For the latter uses, normally small data will be exchanged, so user applications want to receive data unit as soon as possible for

[PATCH] serial/uart: Add tunable RX interrupt trigger I/F of FIFO buffers

2014-02-05 Thread Yoshihiro YUNOMAE
Add tunable RX interrupt trigger I/F of FIFO buffers. Serial devices are used as not only message communication devices but control or sending communication devices. For the latter uses, normally small data will be exchanged, so user applications want to receive data unit as soon as possible for