Re: [PATCH] serial: 8250: fix null-ptr-deref in serial8250_start_tx()

2020-07-21 Thread liwei (GF)
Hi Yingliang, On 2020/7/21 22:38, Yang Yingliang wrote: (SNIP) > > SERIAL_PORT_DFNS is not defined on each arch, if it's not defined, > serial8250_set_defaults() won't be called in serial8250_isa_init_ports(), > so the p->serial_in pointer won't be initialized, and it leads a > null-ptr-deref.

Re: [PATCH] serial: 8250: fix null-ptr-deref in serial8250_start_tx()

2020-07-21 Thread Greg KH
On Tue, Jul 21, 2020 at 08:18:11PM +0800, Yang Yingliang wrote: > > On 2020/7/21 19:54, Yang Yingliang wrote: > > > > On 2020/7/21 18:48, Greg KH wrote: > > > On Tue, Jul 21, 2020 at 02:38:52PM +, Yang Yingliang wrote: > > > > I got null-ptr-deref in serial8250_start_tx(): > > > > > > > > [ 

Re: [PATCH] serial: 8250: fix null-ptr-deref in serial8250_start_tx()

2020-07-21 Thread Yang Yingliang
On 2020/7/21 19:54, Yang Yingliang wrote: On 2020/7/21 18:48, Greg KH wrote: On Tue, Jul 21, 2020 at 02:38:52PM +, Yang Yingliang wrote: I got null-ptr-deref in serial8250_start_tx(): [   78.114630] Unable to handle kernel NULL pointer dereference at virtual address

Re: [PATCH] serial: 8250: fix null-ptr-deref in serial8250_start_tx()

2020-07-21 Thread Yang Yingliang
On 2020/7/21 18:48, Greg KH wrote: On Tue, Jul 21, 2020 at 02:38:52PM +, Yang Yingliang wrote: I got null-ptr-deref in serial8250_start_tx(): [ 78.114630] Unable to handle kernel NULL pointer dereference at virtual address [ 78.123778] Mem abort info: [ 78.126560]

Re: [PATCH] serial: 8250: fix null-ptr-deref in serial8250_start_tx()

2020-07-21 Thread Greg KH
On Tue, Jul 21, 2020 at 02:38:52PM +, Yang Yingliang wrote: > I got null-ptr-deref in serial8250_start_tx(): > > [ 78.114630] Unable to handle kernel NULL pointer dereference at virtual > address > [ 78.123778] Mem abort info: > [ 78.126560] ESR = 0x8607 > [

[PATCH] serial: 8250: fix null-ptr-deref in serial8250_start_tx()

2020-07-21 Thread Yang Yingliang
I got null-ptr-deref in serial8250_start_tx(): [ 78.114630] Unable to handle kernel NULL pointer dereference at virtual address [ 78.123778] Mem abort info: [ 78.126560] ESR = 0x8607 [ 78.129603] EC = 0x21: IABT (current EL), IL = 32 bits [ 78.134891] SET =