Re: [PATCH] serial: 8250_early: do not save and restore IER in write callback

2015-10-23 Thread Masahiro Yamada
Hi Peter, 2015-10-23 21:45 GMT+09:00 Peter Hurley : > On 10/22/2015 04:21 AM, Masahiro Yamada wrote: >> The IER has already been masked in early_serial8250_setup(), there is >> no reason to save and restore it every time early_serial8250_write() >> is called. >> >> Let wait_for_xmitr() melt into

Re: [PATCH] serial: 8250_early: do not save and restore IER in write callback

2015-10-23 Thread Peter Hurley
On 10/22/2015 04:21 AM, Masahiro Yamada wrote: > The IER has already been masked in early_serial8250_setup(), there is > no reason to save and restore it every time early_serial8250_write() > is called. > > Let wait_for_xmitr() melt into serial_putc(). Both of these changes are ok with me, but

Re: [PATCH] serial: 8250_early: do not save and restore IER in write callback

2015-10-23 Thread Peter Hurley
On 10/22/2015 04:21 AM, Masahiro Yamada wrote: > The IER has already been masked in early_serial8250_setup(), there is > no reason to save and restore it every time early_serial8250_write() > is called. > > Let wait_for_xmitr() melt into serial_putc(). Both of these changes are ok with me, but

Re: [PATCH] serial: 8250_early: do not save and restore IER in write callback

2015-10-23 Thread Masahiro Yamada
Hi Peter, 2015-10-23 21:45 GMT+09:00 Peter Hurley : > On 10/22/2015 04:21 AM, Masahiro Yamada wrote: >> The IER has already been masked in early_serial8250_setup(), there is >> no reason to save and restore it every time early_serial8250_write() >> is called. >> >> Let

[PATCH] serial: 8250_early: do not save and restore IER in write callback

2015-10-22 Thread Masahiro Yamada
The IER has already been masked in early_serial8250_setup(), there is no reason to save and restore it every time early_serial8250_write() is called. Let wait_for_xmitr() melt into serial_putc(). Signed-off-by: Masahiro Yamada --- drivers/tty/serial/8250/8250_early.c | 20 ++--

[PATCH] serial: 8250_early: do not save and restore IER in write callback

2015-10-22 Thread Masahiro Yamada
The IER has already been masked in early_serial8250_setup(), there is no reason to save and restore it every time early_serial8250_write() is called. Let wait_for_xmitr() melt into serial_putc(). Signed-off-by: Masahiro Yamada ---