Re: [PATCH] serial: omap: Fix IRQ handling return value

2013-08-27 Thread Greg KH
On Tue, Aug 20, 2013 at 08:44:50AM -0700, Kevin Hilman wrote: > +Felipe > > On Wed, Jul 17, 2013 at 6:29 AM, Alexander Savchenko > wrote: > > From: Ruchika Kharwar > > > > Ensure the Interrupt handling routine return IRQ_HANDLED vs > > IRQ_NONE. > > Why? > > By unconditionally returning

Re: [PATCH] serial: omap: Fix IRQ handling return value

2013-08-27 Thread Greg KH
On Tue, Aug 27, 2013 at 07:30:19AM -0700, Kevin Hilman wrote: > Greg, > > > On Tue, Aug 20, 2013 at 8:44 AM, Kevin Hilman wrote: > > +Felipe > > > > On Wed, Jul 17, 2013 at 6:29 AM, Alexander Savchenko > > wrote: > >> From: Ruchika Kharwar > >> > >> Ensure the Interrupt handling routine

Re: [PATCH] serial: omap: Fix IRQ handling return value

2013-08-27 Thread Kevin Hilman
Greg, On Tue, Aug 20, 2013 at 8:44 AM, Kevin Hilman wrote: > +Felipe > > On Wed, Jul 17, 2013 at 6:29 AM, Alexander Savchenko > wrote: >> From: Ruchika Kharwar >> >> Ensure the Interrupt handling routine return IRQ_HANDLED vs >> IRQ_NONE. > > Why? > > By unconditionally returning IRQ_HANDLED,

Re: [PATCH] serial: omap: Fix IRQ handling return value

2013-08-27 Thread Kevin Hilman
Greg, On Tue, Aug 20, 2013 at 8:44 AM, Kevin Hilman khil...@linaro.org wrote: +Felipe On Wed, Jul 17, 2013 at 6:29 AM, Alexander Savchenko oleksandr.savche...@ti.com wrote: From: Ruchika Kharwar ruch...@ti.com Ensure the Interrupt handling routine return IRQ_HANDLED vs IRQ_NONE. Why?

Re: [PATCH] serial: omap: Fix IRQ handling return value

2013-08-27 Thread Greg KH
On Tue, Aug 27, 2013 at 07:30:19AM -0700, Kevin Hilman wrote: Greg, On Tue, Aug 20, 2013 at 8:44 AM, Kevin Hilman khil...@linaro.org wrote: +Felipe On Wed, Jul 17, 2013 at 6:29 AM, Alexander Savchenko oleksandr.savche...@ti.com wrote: From: Ruchika Kharwar ruch...@ti.com Ensure

Re: [PATCH] serial: omap: Fix IRQ handling return value

2013-08-27 Thread Greg KH
On Tue, Aug 20, 2013 at 08:44:50AM -0700, Kevin Hilman wrote: +Felipe On Wed, Jul 17, 2013 at 6:29 AM, Alexander Savchenko oleksandr.savche...@ti.com wrote: From: Ruchika Kharwar ruch...@ti.com Ensure the Interrupt handling routine return IRQ_HANDLED vs IRQ_NONE. Why? By

Re: [PATCH] serial: omap: Fix IRQ handling return value

2013-08-20 Thread Kevin Hilman
+Felipe On Wed, Jul 17, 2013 at 6:29 AM, Alexander Savchenko wrote: > From: Ruchika Kharwar > > Ensure the Interrupt handling routine return IRQ_HANDLED vs > IRQ_NONE. Why? By unconditionally returning IRQ_HANDLED, this patch will surely break systems where the UART IRQ is shared with other

Re: [PATCH] serial: omap: Fix IRQ handling return value

2013-08-20 Thread Kevin Hilman
+Felipe On Wed, Jul 17, 2013 at 6:29 AM, Alexander Savchenko oleksandr.savche...@ti.com wrote: From: Ruchika Kharwar ruch...@ti.com Ensure the Interrupt handling routine return IRQ_HANDLED vs IRQ_NONE. Why? By unconditionally returning IRQ_HANDLED, this patch will surely break systems where

[PATCH] serial: omap: Fix IRQ handling return value

2013-07-17 Thread Alexander Savchenko
From: Ruchika Kharwar Ensure the Interrupt handling routine return IRQ_HANDLED vs IRQ_NONE. Signed-off-by: Ruchika Kharwar Signed-off-by: Alexander Savchenko --- drivers/tty/serial/omap-serial.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

[PATCH] serial: omap: Fix IRQ handling return value

2013-07-17 Thread Alexander Savchenko
From: Ruchika Kharwar ruch...@ti.com Ensure the Interrupt handling routine return IRQ_HANDLED vs IRQ_NONE. Signed-off-by: Ruchika Kharwar ruch...@ti.com Signed-off-by: Alexander Savchenko oleksandr.savche...@ti.com --- drivers/tty/serial/omap-serial.c |4 +--- 1 file changed, 1