Re: [Linux-stm32] [PATCH] serial: stm32: optimize spin lock usage

2021-04-12 Thread dillon min
On 4/12/21, Erwan LE RAY wrote: > Hi Dillon, > > Thanks for your patch. > > Could you please elaborate the use case in your commit message ? Sorry, local_irq_save() plus spin_lock() same to spin_lock_irqsave() There is no deadlock . Please ignore this patch. Thanks Dillon > > Best Regards,

Re: [Linux-stm32] [PATCH] serial: stm32: optimize spin lock usage

2021-04-12 Thread Erwan LE RAY
Hi Dillon, Thanks for your patch. Could you please elaborate the use case in your commit message ? Best Regards, Erwan. On 4/12/21 10:54 AM, dillon min wrote: Hi Greg, On Mon, Apr 12, 2021 at 4:25 PM Greg KH wrote: On Mon, Apr 12, 2021 at 02:50:20PM +0800, dillon min wrote: Hi Greg，

Re: [PATCH] serial: stm32: optimize spin lock usage

2021-04-12 Thread dillon min
Hi Greg, On Mon, Apr 12, 2021 at 4:25 PM Greg KH wrote: > > On Mon, Apr 12, 2021 at 02:50:20PM +0800, dillon min wrote: > > Hi Greg， > > > > Thanks for the quick response, please ignore the last private mail. > > > > On Mon, Apr 12, 2021 at 1:52 PM Greg KH wrote: > > > > > > On Mon, Apr 12,

Re: [PATCH] serial: stm32: optimize spin lock usage

2021-04-12 Thread Greg KH
On Mon, Apr 12, 2021 at 02:50:20PM +0800, dillon min wrote: > Hi Greg， > > Thanks for the quick response, please ignore the last private mail. > > On Mon, Apr 12, 2021 at 1:52 PM Greg KH wrote: > > > > On Mon, Apr 12, 2021 at 12:34:21PM +0800, dillon.min...@gmail.com wrote: > > > From: dillon

Re: [PATCH] serial: stm32: optimize spin lock usage

2021-04-12 Thread dillon min
Hi lkp, Thanks for the reminder. I just noticed this from greg's mail. still waiting for his response about the proper solution for this patch. After that i will update version 2 for it. Your test is really efficient, thanks. Best regards, Dillon. On Mon, Apr 12, 2021 at 3:25 PM kernel test

Re: [PATCH] serial: stm32: optimize spin lock usage

2021-04-12 Thread kernel test robot
Hi, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on stm32/stm32-next] [also build test WARNING on usb/usb-testing v5.12-rc7] [cannot apply to tty/tty-testing next-20210409] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

Re: [PATCH] serial: stm32: optimize spin lock usage

2021-04-12 Thread dillon min
Hi Greg， Thanks for the quick response, please ignore the last private mail. On Mon, Apr 12, 2021 at 1:52 PM Greg KH wrote: > > On Mon, Apr 12, 2021 at 12:34:21PM +0800, dillon.min...@gmail.com wrote: > > From: dillon min > > > > To avoid potential deadlock in spin_lock usage, change to use >

Re: [PATCH] serial: stm32: optimize spin lock usage

2021-04-11 Thread Greg KH
On Mon, Apr 12, 2021 at 12:34:21PM +0800, dillon.min...@gmail.com wrote: > From: dillon min > > To avoid potential deadlock in spin_lock usage, change to use > spin_lock_irqsave(), spin_unlock_irqrestore() in process(thread_fn) context. > spin_lock(), spin_unlock() under handler context. > >

[PATCH] serial: stm32: optimize spin lock usage

2021-04-11 Thread dillon . minfei
From: dillon min To avoid potential deadlock in spin_lock usage, change to use spin_lock_irqsave(), spin_unlock_irqrestore() in process(thread_fn) context. spin_lock(), spin_unlock() under handler context. remove unused local_irq_save/restore call. Signed-off-by: dillon min --- Was verified