[PATCH] sk98lin: handle pci_enable_device() return value in skge_resume() [resend]

2007-02-27 Thread Dmitriy Monakhov
Signed-off-by: Monakhov Dmitriy <[EMAIL PROTECTED]> --- drivers/net/sk98lin/skge.c | 20 +++- 1 files changed, 15 insertions(+), 5 deletions(-) diff --git a/drivers/net/sk98lin/skge.c b/drivers/net/sk98lin/skge.c index e94ab25..eea753a 100644 --- a/drivers/net/sk98lin/skge.c

[PATCH] sk98lin: handle pci_enable_device() return value in skge_resume() [resend]

2007-02-27 Thread Dmitriy Monakhov
Signed-off-by: Monakhov Dmitriy [EMAIL PROTECTED] --- drivers/net/sk98lin/skge.c | 20 +++- 1 files changed, 15 insertions(+), 5 deletions(-) diff --git a/drivers/net/sk98lin/skge.c b/drivers/net/sk98lin/skge.c index e94ab25..eea753a 100644 --- a/drivers/net/sk98lin/skge.c +++

Re: [PATCH] sk98lin: handle pci_enable_device() return value in skge_resume()

2007-02-24 Thread Dmitriy Monakhov
ke: <<<<< Ok what happend if we jump here right after pci_enable_device() has failed, but pci_disable_device() was called anyway, this is wrong and may be fatal because pdev->enable_cnt may becomes negative. >> + >> +return ret; >> + &g

Re: [PATCH] sk98lin: handle pci_enable_device() return value in skge_resume()

2007-02-24 Thread Dmitriy Monakhov
because pdev-enable_cnt may becomes negative. + +return ret; + } #else #define skge_suspend NULL This is reworked Jiri's patch: [PATCH] sk98lin: handle pci_enable_device() return value in skge_resume() Signed-off-by: Monakhov Dmitriy [EMAIL PROTECTED] --- drivers/net/sk98lin

[PATCH] sk98lin: handle pci_enable_device() return value in skge_resume()

2007-02-23 Thread Dmitriy Monakhov
locFlag &= ~SK_ALLOC_IRQ; > + dev->irq = 0; > + pci_disable_device(pdev); <<<<< Ok what happend if we jump here right after pci_disable_device() has failed, but pci_disable_device() was called anyway, this is wrong and may be fatal because pdev-&g

[PATCH] sk98lin: handle pci_enable_device() return value in skge_resume()

2007-02-23 Thread Dmitriy Monakhov
-enable_cnt may becomes negative. + + return ret; + } #else #define skge_suspend NULL This is reworked Jiri's patch: [PATCH] sk98lin: handle pci_enable_device() return value in skge_resume() Signed-off-by: Monakhov Dmitriy [EMAIL PROTECTED] --- drivers/net/sk98lin/skge.c | 20