Re: [PATCH] slab: remove store_stackinfo()

2019-04-17 Thread Thomas Gleixner
On Tue, 16 Apr 2019, Qian Cai wrote: > store_stackinfo() does not seem used in actual SLAB debugging. > Potentially, it could be added to check_poison_obj() to provide more > information, but this seems like an overkill due to the declining > popularity of the SLAB, so just remove it instead. >

Re: [PATCH] slab: remove store_stackinfo()

2019-04-16 Thread Thomas Gleixner
On Tue, 16 Apr 2019, Vlastimil Babka wrote: > On 4/16/2019 8:50 PM, Thomas Gleixner wrote: > > On Tue, 16 Apr 2019, Vlastimil Babka wrote: > > > >> On 4/16/19 4:22 PM, Qian Cai wrote: > >>> store_stackinfo() does not seem used in actual SLAB debugging. > >>> Potentially, it could be added to

Re: [PATCH] slab: remove store_stackinfo()

2019-04-16 Thread Vlastimil Babka
On 4/16/2019 8:50 PM, Thomas Gleixner wrote: > On Tue, 16 Apr 2019, Vlastimil Babka wrote: > >> On 4/16/19 4:22 PM, Qian Cai wrote: >>> store_stackinfo() does not seem used in actual SLAB debugging. >>> Potentially, it could be added to check_poison_obj() to provide more >>> information, but this

Re: [PATCH] slab: remove store_stackinfo()

2019-04-16 Thread Thomas Gleixner
On Tue, 16 Apr 2019, Vlastimil Babka wrote: > On 4/16/19 4:22 PM, Qian Cai wrote: > > store_stackinfo() does not seem used in actual SLAB debugging. > > Potentially, it could be added to check_poison_obj() to provide more > > information, but this seems like an overkill due to the declining > >

Re: [PATCH] slab: remove store_stackinfo()

2019-04-16 Thread Qian Cai
On 4/16/19 11:25 AM, Vlastimil Babka wrote: > On 4/16/19 4:22 PM, Qian Cai wrote: >> store_stackinfo() does not seem used in actual SLAB debugging. >> Potentially, it could be added to check_poison_obj() to provide more >> information, but this seems like an overkill due to the declining >>

Re: [PATCH] slab: remove store_stackinfo()

2019-04-16 Thread Vlastimil Babka
On 4/16/19 4:22 PM, Qian Cai wrote: > store_stackinfo() does not seem used in actual SLAB debugging. > Potentially, it could be added to check_poison_obj() to provide more > information, but this seems like an overkill due to the declining > popularity of the SLAB, so just remove it instead. > >

[PATCH] slab: remove store_stackinfo()

2019-04-16 Thread Qian Cai
store_stackinfo() does not seem used in actual SLAB debugging. Potentially, it could be added to check_poison_obj() to provide more information, but this seems like an overkill due to the declining popularity of the SLAB, so just remove it instead. Signed-off-by: Qian Cai --- mm/slab.c | 48