Re: [PATCH] sm501: Add device property

2016-06-28 Thread Yoshinori Sato
On Tue, 28 Jun 2016 16:49:08 +0900, Lee Jones wrote: > > On Tue, 28 Jun 2016, Yoshinori Sato wrote: > > > This driver have configuration parameter "device" in platform_data. > > But don't have it in devicetree. > > > > This patch add "device" configuration to devicetree. > > This is really

Re: [PATCH] sm501: Add device property

2016-06-28 Thread Yoshinori Sato
On Tue, 28 Jun 2016 16:49:08 +0900, Lee Jones wrote: > > On Tue, 28 Jun 2016, Yoshinori Sato wrote: > > > This driver have configuration parameter "device" in platform_data. > > But don't have it in devicetree. > > > > This patch add "device" configuration to devicetree. > > This is really

Re: [PATCH] sm501: Add device property

2016-06-28 Thread Lee Jones
On Tue, 28 Jun 2016, Yoshinori Sato wrote: > This driver have configuration parameter "device" in platform_data. > But don't have it in devicetree. > > This patch add "device" configuration to devicetree. This is really ugly. 1. Where are you documenting the binding? 2. Just because it's in

Re: [PATCH] sm501: Add device property

2016-06-28 Thread Lee Jones
On Tue, 28 Jun 2016, Yoshinori Sato wrote: > This driver have configuration parameter "device" in platform_data. > But don't have it in devicetree. > > This patch add "device" configuration to devicetree. This is really ugly. 1. Where are you documenting the binding? 2. Just because it's in

[PATCH] sm501: Add device property

2016-06-28 Thread Yoshinori Sato
This driver have configuration parameter "device" in platform_data. But don't have it in devicetree. This patch add "device" configuration to devicetree. Signed-off-by: Yoshinori Sato --- drivers/mfd/sm501.c | 9 + 1 file changed, 9 insertions(+) diff --git

[PATCH] sm501: Add device property

2016-06-28 Thread Yoshinori Sato
This driver have configuration parameter "device" in platform_data. But don't have it in devicetree. This patch add "device" configuration to devicetree. Signed-off-by: Yoshinori Sato --- drivers/mfd/sm501.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/mfd/sm501.c