Re: [PATCH] soc: mediatek: Handle return of of_match_device function

2018-02-01 Thread Robin Murphy
On 01/02/18 15:09, Geert Uytterhoeven wrote: On Thu, Feb 1, 2018 at 4:02 PM, Robin Murphy wrote: On 01/02/18 11:00, Himanshu Jha wrote: In scpsys_probe function, return value of of_match_device function which returns null is dereferenced without checking. Therefore, add

Re: [PATCH] soc: mediatek: Handle return of of_match_device function

2018-02-01 Thread Robin Murphy
On 01/02/18 15:09, Geert Uytterhoeven wrote: On Thu, Feb 1, 2018 at 4:02 PM, Robin Murphy wrote: On 01/02/18 11:00, Himanshu Jha wrote: In scpsys_probe function, return value of of_match_device function which returns null is dereferenced without checking. Therefore, add a check for potential

Re: [PATCH] soc: mediatek: Handle return of of_match_device function

2018-02-01 Thread Geert Uytterhoeven
On Thu, Feb 1, 2018 at 4:02 PM, Robin Murphy wrote: > On 01/02/18 11:00, Himanshu Jha wrote: >> In scpsys_probe function, return value of of_match_device function which >> returns null is dereferenced without checking. Therefore, add a check for >> potential null

Re: [PATCH] soc: mediatek: Handle return of of_match_device function

2018-02-01 Thread Geert Uytterhoeven
On Thu, Feb 1, 2018 at 4:02 PM, Robin Murphy wrote: > On 01/02/18 11:00, Himanshu Jha wrote: >> In scpsys_probe function, return value of of_match_device function which >> returns null is dereferenced without checking. Therefore, add a check for >> potential null dereference. >> >> Detected by

Re: [PATCH] soc: mediatek: Handle return of of_match_device function

2018-02-01 Thread Robin Murphy
On 01/02/18 11:00, Himanshu Jha wrote: In scpsys_probe function, return value of of_match_device function which returns null is dereferenced without checking. Therefore, add a check for potential null dereference. Detected by CoverityScan, CID#1424087 "Dereference null return value" Fixes:

Re: [PATCH] soc: mediatek: Handle return of of_match_device function

2018-02-01 Thread Robin Murphy
On 01/02/18 11:00, Himanshu Jha wrote: In scpsys_probe function, return value of of_match_device function which returns null is dereferenced without checking. Therefore, add a check for potential null dereference. Detected by CoverityScan, CID#1424087 "Dereference null return value" Fixes:

Re: [PATCH] soc: mediatek: Handle return of of_match_device function

2018-02-01 Thread Alexandre Belloni
On 01/02/2018 at 16:30:22 +0530, Himanshu Jha wrote: > In scpsys_probe function, return value of of_match_device function which > returns null is dereferenced without checking. Therefore, add a check for > potential null dereference. > > Detected by CoverityScan, CID#1424087 "Dereference null

Re: [PATCH] soc: mediatek: Handle return of of_match_device function

2018-02-01 Thread Alexandre Belloni
On 01/02/2018 at 16:30:22 +0530, Himanshu Jha wrote: > In scpsys_probe function, return value of of_match_device function which > returns null is dereferenced without checking. Therefore, add a check for > potential null dereference. > > Detected by CoverityScan, CID#1424087 "Dereference null

Re: [PATCH] soc: mediatek: Handle return of of_match_device function

2018-02-01 Thread Geert Uytterhoeven
Hi Himanshu, On Thu, Feb 1, 2018 at 12:00 PM, Himanshu Jha wrote: > In scpsys_probe function, return value of of_match_device function which > returns null is dereferenced without checking. Therefore, add a check for > potential null dereference. > > Detected by

Re: [PATCH] soc: mediatek: Handle return of of_match_device function

2018-02-01 Thread Geert Uytterhoeven
Hi Himanshu, On Thu, Feb 1, 2018 at 12:00 PM, Himanshu Jha wrote: > In scpsys_probe function, return value of of_match_device function which > returns null is dereferenced without checking. Therefore, add a check for > potential null dereference. > > Detected by CoverityScan, CID#1424087

[PATCH] soc: mediatek: Handle return of of_match_device function

2018-02-01 Thread Himanshu Jha
In scpsys_probe function, return value of of_match_device function which returns null is dereferenced without checking. Therefore, add a check for potential null dereference. Detected by CoverityScan, CID#1424087 "Dereference null return value" Fixes: commit 53fddb1a66dd ("soc: mediatek: reduce

[PATCH] soc: mediatek: Handle return of of_match_device function

2018-02-01 Thread Himanshu Jha
In scpsys_probe function, return value of of_match_device function which returns null is dereferenced without checking. Therefore, add a check for potential null dereference. Detected by CoverityScan, CID#1424087 "Dereference null return value" Fixes: commit 53fddb1a66dd ("soc: mediatek: reduce