Re: [PATCH] soc: qcom: pmic_glink_altmode: Print error when retimer setup fails

2023-10-16 Thread Bjorn Andersson
On Mon, Oct 16, 2023 at 08:56:31AM +0200, Luca Weiss wrote: > On Mon Oct 16, 2023 at 5:18 AM CEST, Bjorn Andersson wrote: > > On Fri, Oct 13, 2023 at 03:56:40PM +0200, Luca Weiss wrote: > > > It can be useful to know with which return value the retimer_set call > > > failed, so include this info

Re: [PATCH] soc: qcom: pmic_glink_altmode: Print error when retimer setup fails

2023-10-16 Thread Luca Weiss
On Mon Oct 16, 2023 at 5:18 AM CEST, Bjorn Andersson wrote: > On Fri, Oct 13, 2023 at 03:56:40PM +0200, Luca Weiss wrote: > > It can be useful to know with which return value the retimer_set call > > failed, so include this info in the dev_err print. > > > > Is this useful during development, or

Re: [PATCH] soc: qcom: pmic_glink_altmode: Print error when retimer setup fails

2023-10-15 Thread Bjorn Andersson
On Fri, Oct 13, 2023 at 03:56:40PM +0200, Luca Weiss wrote: > It can be useful to know with which return value the retimer_set call > failed, so include this info in the dev_err print. > Is this useful during development, or during normal execution etc. How about using kretprobe or similar

Re: [PATCH] soc: qcom: pmic_glink_altmode: Print error when retimer setup fails

2023-10-13 Thread Konrad Dybcio
On 13.10.2023 15:56, Luca Weiss wrote: > It can be useful to know with which return value the retimer_set call > failed, so include this info in the dev_err print. > > Signed-off-by: Luca Weiss > --- Reviewed-by: Konrad Dybcio Konrad

[PATCH] soc: qcom: pmic_glink_altmode: Print error when retimer setup fails

2023-10-13 Thread Luca Weiss
It can be useful to know with which return value the retimer_set call failed, so include this info in the dev_err print. Signed-off-by: Luca Weiss --- drivers/soc/qcom/pmic_glink_altmode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/qcom/pmic_glink_altmode.c