Re: [PATCH] sound: usb: pcm: fix incorrect power state when playing sound after PM_AUTO suspend

2020-06-03 Thread Macpaul Lin
On Wed, 2020-06-03 at 14:47 +0200, Takashi Iwai wrote: > On Wed, 03 Jun 2020 14:39:24 +0200, > Macpaul Lin wrote: > > > > On Wed, 2020-06-03 at 10:45 +0200, Takashi Iwai wrote: > > > On Wed, 03 Jun 2020 08:54:51 +0200, > > > Takashi Iwai wrote: > > > > > > > > On Wed, 03 Jun 2020 08:28:09 +0200,

Re: [PATCH] sound: usb: pcm: fix incorrect power state when playing sound after PM_AUTO suspend

2020-06-03 Thread Takashi Iwai
On Wed, 03 Jun 2020 14:39:24 +0200, Macpaul Lin wrote: > > On Wed, 2020-06-03 at 10:45 +0200, Takashi Iwai wrote: > > On Wed, 03 Jun 2020 08:54:51 +0200, > > Takashi Iwai wrote: > > > > > > On Wed, 03 Jun 2020 08:28:09 +0200, > > > Takashi Iwai wrote: > > > > > > > > And, the most suspicious

Re: [PATCH] sound: usb: pcm: fix incorrect power state when playing sound after PM_AUTO suspend

2020-06-03 Thread Macpaul Lin
On Wed, 2020-06-03 at 10:45 +0200, Takashi Iwai wrote: > On Wed, 03 Jun 2020 08:54:51 +0200, > Takashi Iwai wrote: > > > > On Wed, 03 Jun 2020 08:28:09 +0200, > > Takashi Iwai wrote: > > > > > > And, the most suspicious case is the last one, > > > chip->num_suspended-intf. It means that the

Re: [PATCH] sound: usb: pcm: fix incorrect power state when playing sound after PM_AUTO suspend

2020-06-03 Thread Takashi Iwai
On Wed, 03 Jun 2020 08:54:51 +0200, Takashi Iwai wrote: > > On Wed, 03 Jun 2020 08:28:09 +0200, > Takashi Iwai wrote: > > > > And, the most suspicious case is the last one, > > chip->num_suspended-intf. It means that the device has multiple > > USB interfaces and they went to suspend, while the

Re: [PATCH] sound: usb: pcm: fix incorrect power state when playing sound after PM_AUTO suspend

2020-06-03 Thread Takashi Iwai
On Wed, 03 Jun 2020 08:28:09 +0200, Takashi Iwai wrote: > > And, the most suspicious case is the last one, > chip->num_suspended-intf. It means that the device has multiple > USB interfaces and they went to suspend, while the resume isn't > performed for the all suspended interfaces in return.

Re: [PATCH] sound: usb: pcm: fix incorrect power state when playing sound after PM_AUTO suspend

2020-06-03 Thread Takashi Iwai
On Wed, 03 Jun 2020 05:05:15 +0200, Macpaul Lin wrote: > > On Tue, 2020-06-02 at 14:46 +0200, Takashi Iwai wrote: > > On Tue, 02 Jun 2020 13:53:41 +0200, > > Macpaul Lin wrote: > > > > > > This patch fix incorrect power state changed by usb_audio_suspend() > > > when CONFIG_PM is enabled. > > >

Re: [PATCH] sound: usb: pcm: fix incorrect power state when playing sound after PM_AUTO suspend

2020-06-02 Thread Macpaul Lin
On Tue, 2020-06-02 at 14:46 +0200, Takashi Iwai wrote: > On Tue, 02 Jun 2020 13:53:41 +0200, > Macpaul Lin wrote: > > > > This patch fix incorrect power state changed by usb_audio_suspend() > > when CONFIG_PM is enabled. > > > > After receiving suspend PM message with auto flag,

Re: [PATCH] sound: usb: pcm: fix incorrect power state when playing sound after PM_AUTO suspend

2020-06-02 Thread Takashi Iwai
On Tue, 02 Jun 2020 13:53:41 +0200, Macpaul Lin wrote: > > This patch fix incorrect power state changed by usb_audio_suspend() > when CONFIG_PM is enabled. > > After receiving suspend PM message with auto flag, usb_audio_suspend() > change card's power state to SNDRV_CTL_POWER_D3hot. Only when

Re: [PATCH] sound: usb: pcm: fix incorrect power state when playing sound after PM_AUTO suspend

2020-06-02 Thread Macpaul Lin
On Tue, 2020-06-02 at 19:53 +0800, Macpaul Lin wrote: > This patch fix incorrect power state changed by usb_audio_suspend() > when CONFIG_PM is enabled. > > After receiving suspend PM message with auto flag, usb_audio_suspend() > change card's power state to SNDRV_CTL_POWER_D3hot. Only when the

[PATCH] sound: usb: pcm: fix incorrect power state when playing sound after PM_AUTO suspend

2020-06-02 Thread Macpaul Lin
This patch fix incorrect power state changed by usb_audio_suspend() when CONFIG_PM is enabled. After receiving suspend PM message with auto flag, usb_audio_suspend() change card's power state to SNDRV_CTL_POWER_D3hot. Only when the other resume PM message with auto flag can change power state to