RE: [PATCH] soundwire: add slave device to linked list after device_register()

2021-04-18 Thread Liao, Bard
m; > srinivas.kandaga...@linaro.org; Kale, Sanyog R ; > rander.w...@linux.intel.com; Liao, Bard > Subject: Re: [PATCH] soundwire: add slave device to linked list after > device_register() > > Hi Vinod, > > >> We currently add the slave device to a linked list b

Re: [PATCH] soundwire: add slave device to linked list after device_register()

2021-03-23 Thread Pierre-Louis Bossart
Hi Vinod, We currently add the slave device to a linked list before device_register(), and then remove it if device_register() fails. It's not clear why this sequence was necessary, this patch moves the linked list management to after the device_register(). Maybe add a comment :-) The reason

Re: [PATCH] soundwire: add slave device to linked list after device_register()

2021-03-22 Thread Vinod Koul
On 23-03-21, 10:25, Bard Liao wrote: > From: Pierre-Louis Bossart > > We currently add the slave device to a linked list before > device_register(), and then remove it if device_register() fails. > > It's not clear why this sequence was necessary, this patch moves the > linked list management to

[PATCH] soundwire: add slave device to linked list after device_register()

2021-03-22 Thread Bard Liao
From: Pierre-Louis Bossart We currently add the slave device to a linked list before device_register(), and then remove it if device_register() fails. It's not clear why this sequence was necessary, this patch moves the linked list management to after the device_register(). Suggested-by: Keyon