Re: [PATCH] spi/s3c64xx: Fix doubled clock disable on suspend

2013-10-21 Thread Krzysztof Kozlowski
On Mon, 2013-10-21 at 11:42 +0200, Sylwester Nawrocki wrote: > pm_runtime_{get,put}* must not be called from drivers's system suspend/resume > callbacks. Please use pm_runtime_suspended() to check device runtime PM status > in s3c64xx_spi_{suspend,resume} callbacks and handle the clocks

Re: [PATCH] spi/s3c64xx: Fix doubled clock disable on suspend

2013-10-21 Thread Sylwester Nawrocki
On 21/10/13 11:35, Krzysztof Kozlowski wrote: > Fix doubled clock disable and unprepare during PM suspend which triggered > the warnings: [...] > The clocks are already disabled before suspending. > > Additionally add PM runtime get() and put() during resume so device > won't sleep for the time

[PATCH] spi/s3c64xx: Fix doubled clock disable on suspend

2013-10-21 Thread Krzysztof Kozlowski
Fix doubled clock disable and unprepare during PM suspend which triggered the warnings: WARNING: at drivers/clk/clk.c:800 clk_disable+0x18/0x24() Modules linked in: CPU: 0 PID: 1745 Comm: sh Not tainted 3.10.14-01211-ge2549bb-dirty #62 [] (unwind_backtrace+0x0/0x138) from []

[PATCH] spi/s3c64xx: Fix doubled clock disable on suspend

2013-10-21 Thread Krzysztof Kozlowski
Fix doubled clock disable and unprepare during PM suspend which triggered the warnings: WARNING: at drivers/clk/clk.c:800 clk_disable+0x18/0x24() Modules linked in: CPU: 0 PID: 1745 Comm: sh Not tainted 3.10.14-01211-ge2549bb-dirty #62 [c0015980] (unwind_backtrace+0x0/0x138) from [c0012a44]

Re: [PATCH] spi/s3c64xx: Fix doubled clock disable on suspend

2013-10-21 Thread Sylwester Nawrocki
On 21/10/13 11:35, Krzysztof Kozlowski wrote: Fix doubled clock disable and unprepare during PM suspend which triggered the warnings: [...] The clocks are already disabled before suspending. Additionally add PM runtime get() and put() during resume so device won't sleep for the time of

Re: [PATCH] spi/s3c64xx: Fix doubled clock disable on suspend

2013-10-21 Thread Krzysztof Kozlowski
On Mon, 2013-10-21 at 11:42 +0200, Sylwester Nawrocki wrote: pm_runtime_{get,put}* must not be called from drivers's system suspend/resume callbacks. Please use pm_runtime_suspended() to check device runtime PM status in s3c64xx_spi_{suspend,resume} callbacks and handle the clocks